Re: [PATCH 22/22] iwlwifi: remove the code under IWLWIFI_PCIE_RTPM

[Kalle Valo <kvalo@codeaurora.org>]

Luca Coelho <luca@coelho.fi> writes:

> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>
> This is never set.
>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig    | 14 ----
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 71 -------------------
>  .../net/wireless/intel/iwlwifi/pcie/trans.c   |  4 --
>  3 files changed, 89 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 235349a33a3c..7dbc0d38bb3b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -92,20 +92,6 @@ config IWLWIFI_BCAST_FILTERING
>  	  If unsure, don't enable this option, as some programs might
>  	  expect incoming broadcasts for their normal operations.
>  
> -config IWLWIFI_PCIE_RTPM
> -       bool "Enable runtime power management mode for PCIe devices"
> -       depends on IWLMVM && PM && EXPERT
> -       help
> -         Say Y here to enable runtime power management for PCIe
> -         devices.  If enabled, the device will go into low power mode
> -         when idle for a short period of time, allowing for improved
> -         power saving during runtime. Note that this feature requires
> -         a tight integration with the platform. It is not recommended
> -         to enable this feature without proper validation with the
> -         specific target platform.
> -
> -	 If unsure, say N.

I would like to have more understanding why you are removing an existing
Kconfig option? "Never set" tells nothing.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches