From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>, "Michael Büsch" <m@bues.ch>,
"Matt Redfearn" <matt.redfearn@mips.com>,
linux-wireless@vger.kernel.org,
"Hauke Mehrtens" <hauke@hauke-m.de>,
LKML <linux-kernel@vger.kernel.org>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
Date: Fri, 11 May 2018 13:18:30 +0300 [thread overview]
Message-ID: <8736yycx6x.fsf@codeaurora.org> (raw)
In-Reply-To: <ff18cb0a-e878-dff4-777b-134f0f3fe2e5@lwfinger.net> (Larry Finger's message of "Thu, 10 May 2018 11:07:09 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 05/10/2018 06:14 AM, Rafa=C5=82 Mi=C5=82ecki wrote:
>> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>
>> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
>> symbols pcibios_enable_device and register_pci_controller. This code is
>> supposed to be compiled only with ssb builtin.
>>
>> This fixes:
>> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
>> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>
>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> This patch needs a "Reported-by: Matt Redfearn <matt.redfearn@mips.com>".
>
> Applying both patches leads to a correct configuration for PCI. I
> cannot test on my present hardware, but the patches seem to be
> correct.
>
> Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> @Kalle: Please drop my patch from yesterday. This solution is much better.
Dropped, thanks for letting me know.
--=20
Kalle Valo
prev parent reply other threads:[~2018-05-11 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 11:14 [PATCH 4.17 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-10 11:17 ` Michael Büsch
2018-05-10 11:20 ` Rafał Miłecki
2018-05-10 11:26 ` Michael Büsch
2018-05-10 11:35 ` Matt Redfearn
2018-05-10 11:35 ` Rafał Miłecki
2018-05-10 16:07 ` Larry Finger
2018-05-11 10:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736yycx6x.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=matt.redfearn@mips.com \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).