From: Kalle Valo <kvalo@codeaurora.org>
To: <pkshih@realtek.com>
Cc: <Larry.Finger@lwfinger.net>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 7/9] rtlwifi: btcoex: Add modifier const to version related variables
Date: Wed, 28 Mar 2018 17:35:17 +0300 [thread overview]
Message-ID: <87370knu8q.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180328072741.23349-8-pkshih@realtek.com> (pkshih@realtek.com's message of "Wed, 28 Mar 2018 15:27:39 +0800")
<pkshih@realtek.com> writes:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> The variables declared as 'static' look a little weird. Since they are
> version of btcoex and only used to display in debug message, this patch
> changes them to 'static const' to make it clear.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
That's a good idea, thanks.
--
Kalle Valo
next prev parent reply other threads:[~2018-03-28 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 7:27 [PATCH 0/9] rtlwifi: btcoex: Add 8822b btcoex support pkshih
2018-03-28 7:27 ` [PATCH 1/9] rtlwifi: btcoex: Add 8822b1ant coex files pkshih
2018-04-04 2:43 ` Larry Finger
2018-04-04 12:41 ` Pkshih
2018-04-04 12:45 ` Pkshih
2018-03-28 7:27 ` [PATCH 2/9] rtlwifi: btcoex: Add 8822b2ant " pkshih
2018-03-28 7:27 ` [PATCH 3/9] rtlwifi: btcoex: Add 8822b header files to precomp.h pkshih
2018-03-28 7:27 ` [PATCH 4/9] rtlwifi: btcoex: Add 8822b routine to btc interfaces pkshih
2018-03-28 7:27 ` [PATCH 5/9] rtlwifi: btcoex: Add 8822b to Makefile pkshih
2018-03-28 7:27 ` [PATCH 6/9] rtlwifi: btcoex: remove comments that are not meaningful pkshih
2018-03-28 7:27 ` [PATCH 7/9] rtlwifi: btcoex: Add modifier const to version related variables pkshih
2018-03-28 14:35 ` Kalle Valo [this message]
2018-03-28 7:27 ` [PATCH 8/9] rtlwifi: btcoex: Add struct members to replace global varaibles pkshih
2018-03-28 7:27 ` [PATCH 9/9] rtlwifi: btcoex: Remove global variables of chip specific context pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87370knu8q.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).