From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c
Date: Thu, 17 Aug 2017 06:49:40 +0000 [thread overview]
Message-ID: <87378q664c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <ec54c0ff3af546d2a52d75428c38d06b@euamsexm01a.eu.qualcomm.com> (Kalle Valo's message of "Thu, 17 Aug 2017 06:20:02 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>
>> In preparation to add RAM dump support. No functional changes, only movi=
ng code
>> and renaming function names.
>>=20
>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>
> With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a=
build error:
>
> drivers/net/wireless/ath/ath10k/coredump.c:24:30: error: redefinition
> of 'ath10k_coredump_new'
> drivers/net/wireless/ath/ath10k/coredump.c:130:5: error: redefinition
> of 'ath10k_coredump_submit'
Fixed in pending branch like this:
--- a/drivers/net/wireless/ath/ath10k/Makefile
+++ b/drivers/net/wireless/ath/ath10k/Makefile
@@ -20,7 +20,7 @@ ath10k_core-$(CONFIG_ATH10K_TRACING) +=3D trace.o
ath10k_core-$(CONFIG_THERMAL) +=3D thermal.o
ath10k_core-$(CONFIG_MAC80211_DEBUGFS) +=3D debugfs_sta.o
ath10k_core-$(CONFIG_PM) +=3D wow.o
-ath10k_core-$(CONFIG_ATH10K_DEBUGFS) +=3D coredump.o
+ath10k_core-$(CONFIG_DEV_COREDUMP) +=3D coredump.o
--=20
Kalle Valo=
next prev parent reply other threads:[~2017-08-17 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 8:22 [PATCH 0/6] ath10k: firmware ramdump support Kalle Valo
2017-08-15 8:22 ` [PATCH 1/6] ath10k: remove deprecated fw_crash_dump debugfs file Kalle Valo
2017-08-15 8:23 ` [PATCH 2/6] ath10k: refactor firmware crashdump code to coredump.c Kalle Valo
2017-08-17 4:20 ` [2/6] " Kalle Valo
2017-08-17 6:49 ` Kalle Valo [this message]
2017-08-15 8:23 ` [PATCH 3/6] ath10k: detach coredump.c from debug.c Kalle Valo
2017-08-15 8:23 ` [PATCH 4/6] ath10k: add coredump_mask module parameter Kalle Valo
2017-08-15 8:23 ` [PATCH 5/6] ath10k: add memory dump support for QCA6174/QCA9377 Kalle Valo
2017-08-15 11:33 ` [5/6] " Kalle Valo
2017-08-15 17:42 ` [PATCH 5/6] " Ben Greear
2017-11-01 10:49 ` Kalle Valo
2017-08-15 8:23 ` [PATCH 6/6] ath10k: add memory dump support QCA988X Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87378q664c.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).