* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' [not found] ` <ce7467a9-12d5-f64e-8b59-f9581db9f7c8@infradead.org> @ 2017-02-16 9:31 ` Kalle Valo 2017-02-16 9:39 ` Rafał Miłecki 0 siblings, 1 reply; 8+ messages in thread From: Kalle Valo @ 2017-02-16 9:31 UTC (permalink / raw) To: Randy Dunlap, Arend Van Spriel, Rafał Miłecki Cc: kbuild test robot, kbuild-all, linux-kernel, linux-wireless (Adding linux-wireless) Randy Dunlap <rdunlap@infradead.org> writes: > On 02/07/17 02:02, kbuild test robot wrote: >> Hi Kalle, >>=20 >> FYI, the error/warning still remains. >>=20 >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it master >> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >> under broadcom vendor directory >> date: 1 year, 3 months ago >> config: mips-allyesconfig (attached as .config) >> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >> reproduce: >> wget >> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbi= n/make.cross >> -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >> # save the attached .config to linux build tree >> make.cross ARCH=3Dmips=20 >>=20 >> All errors (new ones prefixed by >>): > > when both: > > CONFIG_BRCM_TRACING=3Dy > CONFIG_BRCMDBG=3Dy > > but DEBUG is not defined. > > I think it would help if CONFIG_BRCMDBG set DEBUG > or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. Arend or Rafa=C5=82, would you be able to look at this build problem? Kbuild found the build errors below, apparently a very old issue. It just blames me now because I moved the driver to a new directory :) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: >> error: redefinition of 'brcmf_debugfs_init' void brcmf_debugfs_init(void) ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/b= us.h:20:0, from drivers/net/wireless/broadcom/brcm80211/brcmfmac/d= ebug.c:24: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:118:20: note: p= revious definition of 'brcmf_debugfs_init' was here static inline void brcmf_debugfs_init(void) ^~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:65:6: >> error: redefinition of 'brcmf_debugfs_exit' void brcmf_debugfs_exit(void) ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/b= us.h:20:0, from drivers/net/wireless/broadcom/brcm80211/brcmfmac/d= ebug.c:24: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:121:20: note: p= revious definition of 'brcmf_debugfs_exit' was here static inline void brcmf_debugfs_exit(void) ^~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:74:5: >> error: redefinition of 'brcmf_debug_attach' int brcmf_debug_attach(struct brcmf_pub *drvr) ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/b= us.h:20:0, from drivers/net/wireless/broadcom/brcm80211/brcmfmac/d= ebug.c:24: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:124:19: note: p= revious definition of 'brcmf_debug_attach' was here static inline int brcmf_debug_attach(struct brcmf_pub *drvr) ^~~~~~~~~~~~~~~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'b= rcmf_debug_attach': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:81:6: >> error: 'struct brcmf_pub' has no member named 'dbgfs_dir' drvr->dbgfs_dir =3D debugfs_create_dir(dev_name(dev), root_folder); ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:82:17: error: '= struct brcmf_pub' has no member named 'dbgfs_dir' if (IS_ERR(drvr->dbgfs_dir)) ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:83:22: error: '= struct brcmf_pub' has no member named 'dbgfs_dir' return PTR_ERR(drvr->dbgfs_dir); ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:90:6: >> error: redefinition of 'brcmf_debug_detach' void brcmf_debug_detach(struct brcmf_pub *drvr) ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/b= us.h:20:0, from drivers/net/wireless/broadcom/brcm80211/brcmfmac/d= ebug.c:24: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:128:20: note: p= revious definition of 'brcmf_debug_detach' was here static inline void brcmf_debug_detach(struct brcmf_pub *drvr) ^~~~~~~~~~~~~~~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'b= rcmf_debug_detach': drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:94:26: error: '= struct brcmf_pub' has no member named 'dbgfs_dir' if (!IS_ERR_OR_NULL(drvr->dbgfs_dir)) ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:95:32: error: '= struct brcmf_pub' has no member named 'dbgfs_dir' debugfs_remove_recursive(drvr->dbgfs_dir); ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'b= rcmf_debugfs_get_devdir': drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:100:13: error: = 'struct brcmf_pub' has no member named 'dbgfs_dir' return drvr->dbgfs_dir; ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:103:5: >> error: redefinition of 'brcmf_debugfs_add_entry' int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn, ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/b= us.h:20:0, from drivers/net/wireless/broadcom/brcm80211/brcmfmac/d= ebug.c:24: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:132:5: note: pr= evious definition of 'brcmf_debugfs_add_entry' was here int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn, ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'b= rcmf_debugfs_add_entry': drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:109:10: error: = 'struct brcmf_pub' has no member named 'dbgfs_dir' drvr->dbgfs_dir, read_fn); ^~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'b= rcmf_debugfs_get_devdir': drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:101:1: warning:= control reaches end of non-void function [-Wreturn-type] } ^ --=20 Kalle Valo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 9:31 ` drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' Kalle Valo @ 2017-02-16 9:39 ` Rafał Miłecki 2017-02-16 9:53 ` Arend Van Spriel 0 siblings, 1 reply; 8+ messages in thread From: Rafał Miłecki @ 2017-02-16 9:39 UTC (permalink / raw) To: Kalle Valo, Randy Dunlap, Arend Van Spriel Cc: kbuild test robot, kbuild-all, linux-kernel, linux-wireless On 02/16/2017 10:31 AM, Kalle Valo wrote: > (Adding linux-wireless) > > Randy Dunlap <rdunlap@infradead.org> writes: > >> On 02/07/17 02:02, kbuild test robot wrote: >>> Hi Kalle, >>> >>> FYI, the error/warning still remains. >>> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>> under broadcom vendor directory >>> date: 1 year, 3 months ago >>> config: mips-allyesconfig (attached as .config) >>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>> reproduce: >>> wget >>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>> -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>> # save the attached .config to linux build tree >>> make.cross ARCH=mips >>> >>> All errors (new ones prefixed by >>): >> >> when both: >> >> CONFIG_BRCM_TRACING=y >> CONFIG_BRCMDBG=y >> >> but DEBUG is not defined. >> >> I think it would help if CONFIG_BRCMDBG set DEBUG >> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. > > Arend or Rafał, would you be able to look at this build problem? Kbuild > found the build errors below, apparently a very old issue. It just > blames me now because I moved the driver to a new directory :) Something like this maybe? Note I didn't test it with above config. diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h index 6687812770cc..8c7695fde482 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h @@ -108,7 +108,7 @@ do { \ extern int brcmf_msg_level; struct brcmf_pub; -#ifdef DEBUG +#ifdef CONFIG_BRCMDBG void brcmf_debugfs_init(void); void brcmf_debugfs_exit(void); int brcmf_debug_attach(struct brcmf_pub *drvr); ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 9:39 ` Rafał Miłecki @ 2017-02-16 9:53 ` Arend Van Spriel 2017-02-16 10:01 ` Kalle Valo 0 siblings, 1 reply; 8+ messages in thread From: Arend Van Spriel @ 2017-02-16 9:53 UTC (permalink / raw) To: Rafał Miłecki, Kalle Valo, Randy Dunlap Cc: kbuild test robot, kbuild-all, linux-kernel, linux-wireless On 16-2-2017 10:39, Rafał Miłecki wrote: > On 02/16/2017 10:31 AM, Kalle Valo wrote: >> (Adding linux-wireless) >> >> Randy Dunlap <rdunlap@infradead.org> writes: >> >>> On 02/07/17 02:02, kbuild test robot wrote: >>>> Hi Kalle, >>>> >>>> FYI, the error/warning still remains. >>>> >>>> tree: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>> master >>>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>>> under broadcom vendor directory >>>> date: 1 year, 3 months ago >>>> config: mips-allyesconfig (attached as .config) >>>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>>> reproduce: >>>> wget >>>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>>> >>>> -O ~/bin/make.cross >>>> chmod +x ~/bin/make.cross >>>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>>> # save the attached .config to linux build tree >>>> make.cross ARCH=mips >>>> >>>> All errors (new ones prefixed by >>): >>> >>> when both: >>> >>> CONFIG_BRCM_TRACING=y >>> CONFIG_BRCMDBG=y >>> >>> but DEBUG is not defined. >>> >>> I think it would help if CONFIG_BRCMDBG set DEBUG >>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >> >> Arend or Rafał, would you be able to look at this build problem? Kbuild >> found the build errors below, apparently a very old issue. It just >> blames me now because I moved the driver to a new directory :) It is a very old issue. The thing is that the issue can not really occur because we have this: # common flags subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what happens in the "kbuild test robot" scenario. Regards, Arend > Something like this maybe? Note I didn't test it with above config. > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > index 6687812770cc..8c7695fde482 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > @@ -108,7 +108,7 @@ do { \ > extern int brcmf_msg_level; > > struct brcmf_pub; > -#ifdef DEBUG > +#ifdef CONFIG_BRCMDBG > void brcmf_debugfs_init(void); > void brcmf_debugfs_exit(void); > int brcmf_debug_attach(struct brcmf_pub *drvr); > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 9:53 ` Arend Van Spriel @ 2017-02-16 10:01 ` Kalle Valo 2017-02-16 10:30 ` Arend Van Spriel 0 siblings, 1 reply; 8+ messages in thread From: Kalle Valo @ 2017-02-16 10:01 UTC (permalink / raw) To: Arend Van Spriel Cc: Rafał Miłecki, Randy Dunlap, kbuild test robot, kbuild-all, linux-kernel, linux-wireless Arend Van Spriel <arend.vanspriel@broadcom.com> writes: > On 16-2-2017 10:39, Rafa=C5=82 Mi=C5=82ecki wrote: >> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>> (Adding linux-wireless) >>> >>> Randy Dunlap <rdunlap@infradead.org> writes: >>> >>>> On 02/07/17 02:02, kbuild test robot wrote: >>>>> Hi Kalle, >>>>> >>>>> FYI, the error/warning still remains. >>>>> >>>>> tree:=20=20 >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>> master >>>>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>>>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>>>> under broadcom vendor directory >>>>> date: 1 year, 3 months ago >>>>> config: mips-allyesconfig (attached as .config) >>>>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>>>> reproduce: >>>>> wget >>>>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/= sbin/make.cross >>>>> >>>>> -O ~/bin/make.cross >>>>> chmod +x ~/bin/make.cross >>>>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>>>> # save the attached .config to linux build tree >>>>> make.cross ARCH=3Dmips >>>>> >>>>> All errors (new ones prefixed by >>): n>>>> >>>> when both: >>>> >>>> CONFIG_BRCM_TRACING=3Dy >>>> CONFIG_BRCMDBG=3Dy >>>> >>>> but DEBUG is not defined. >>>> >>>> I think it would help if CONFIG_BRCMDBG set DEBUG >>>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >>> >>> Arend or Rafa=C5=82, would you be able to look at this build problem? K= build >>> found the build errors below, apparently a very old issue. It just >>> blames me now because I moved the driver to a new directory :) > > It is a very old issue. The thing is that the issue can not really occur > because we have this: > > # common flags > subdir-ccflags-$(CONFIG_BRCMDBG) +=3D -DDEBUG > > in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what > happens in the "kbuild test robot" scenario. I actually tried to reproduce this with kbuild bot's instructions and was surprised to see that the build worked ok for me. So the issue is not that simple. --=20 Kalle Valo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 10:01 ` Kalle Valo @ 2017-02-16 10:30 ` Arend Van Spriel 2017-02-16 13:08 ` [kbuild-all] " Fengguang Wu 2017-02-16 13:18 ` Kalle Valo 0 siblings, 2 replies; 8+ messages in thread From: Arend Van Spriel @ 2017-02-16 10:30 UTC (permalink / raw) To: Kalle Valo Cc: Rafał Miłecki, Randy Dunlap, kbuild test robot, kbuild-all, linux-kernel, linux-wireless On 16-2-2017 11:01, Kalle Valo wrote: > Arend Van Spriel <arend.vanspriel@broadcom.com> writes: > >> On 16-2-2017 10:39, Rafał Miłecki wrote: >>> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>>> (Adding linux-wireless) >>>> >>>> Randy Dunlap <rdunlap@infradead.org> writes: >>>> >>>>> On 02/07/17 02:02, kbuild test robot wrote: >>>>>> Hi Kalle, >>>>>> >>>>>> FYI, the error/warning still remains. >>>>>> >>>>>> tree: >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>>> master >>>>>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>>>>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>>>>> under broadcom vendor directory >>>>>> date: 1 year, 3 months ago >>>>>> config: mips-allyesconfig (attached as .config) >>>>>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>>>>> reproduce: >>>>>> wget >>>>>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>>>>> >>>>>> -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>>>>> # save the attached .config to linux build tree >>>>>> make.cross ARCH=mips >>>>>> >>>>>> All errors (new ones prefixed by >>): > n>>>> >>>>> when both: >>>>> >>>>> CONFIG_BRCM_TRACING=y >>>>> CONFIG_BRCMDBG=y >>>>> >>>>> but DEBUG is not defined. >>>>> >>>>> I think it would help if CONFIG_BRCMDBG set DEBUG >>>>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >>>> >>>> Arend or Rafał, would you be able to look at this build problem? Kbuild >>>> found the build errors below, apparently a very old issue. It just >>>> blames me now because I moved the driver to a new directory :) >> >> It is a very old issue. The thing is that the issue can not really occur >> because we have this: >> >> # common flags >> subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG >> >> in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what >> happens in the "kbuild test robot" scenario. > > I actually tried to reproduce this with kbuild bot's instructions and > was surprised to see that the build worked ok for me. So the issue is > not that simple. Hi Kalle, Here is the old email exchange we had about this [1]. In my opinion this is a Kbuild issue that needs to be looked into. Regards, Arend [1] http://www.spinics.net/lists/linux-wireless/msg142122.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [kbuild-all] drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 10:30 ` Arend Van Spriel @ 2017-02-16 13:08 ` Fengguang Wu 2017-02-16 13:18 ` Kalle Valo 1 sibling, 0 replies; 8+ messages in thread From: Fengguang Wu @ 2017-02-16 13:08 UTC (permalink / raw) To: Arend Van Spriel Cc: Kalle Valo, Randy Dunlap, linux-wireless, linux-kernel, kbuild-all, Rafał Miłecki, Philip Li Hi all, Yes sorry, it's a false report related to how we do bisects. >>>>>> CONFIG_BRCM_TRACING=y >>>>>> CONFIG_BRCMDBG=y >>>>>> >>>>>> but DEBUG is not defined. >>>>>> >>>>>> I think it would help if CONFIG_BRCMDBG set DEBUG >>>>>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >>>>> >>>>> Arend or Rafał, would you be able to look at this build problem? Kbuild >>>>> found the build errors below, apparently a very old issue. It just >>>>> blames me now because I moved the driver to a new directory :) >>> >>> It is a very old issue. The thing is that the issue can not really occur >>> because we have this: >>> >>> # common flags >>> subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG >>> >>> in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what >>> happens in the "kbuild test robot" scenario. As an optimization, the robot often does "partial builds" during bisects. For example, when the error is found in drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c It'll try make drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.o And verify the bisect result with make drivers/net/wireless/broadcom/brcm80211/brcmfmac/ However in this case the whole dir is moved, so both logics failed to give correct results. We'll check how to improve this. Sorry for the confusions! >> I actually tried to reproduce this with kbuild bot's instructions and >> was surprised to see that the build worked ok for me. So the issue is >> not that simple. > >Hi Kalle, > >Here is the old email exchange we had about this [1]. In my opinion this >is a Kbuild issue that needs to be looked into. > >Regards, >Arend > >[1] http://www.spinics.net/lists/linux-wireless/msg142122.html Thanks, Fengguang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 10:30 ` Arend Van Spriel 2017-02-16 13:08 ` [kbuild-all] " Fengguang Wu @ 2017-02-16 13:18 ` Kalle Valo 2017-02-17 1:45 ` [kbuild-all] " Fengguang Wu 1 sibling, 1 reply; 8+ messages in thread From: Kalle Valo @ 2017-02-16 13:18 UTC (permalink / raw) To: Arend Van Spriel Cc: Rafał Miłecki, Randy Dunlap, kbuild test robot, kbuild-all, linux-kernel, linux-wireless Arend Van Spriel <arend.vanspriel@broadcom.com> writes: > On 16-2-2017 11:01, Kalle Valo wrote: >> Arend Van Spriel <arend.vanspriel@broadcom.com> writes: >>=20 >>> On 16-2-2017 10:39, Rafa=C5=82 Mi=C5=82ecki wrote: >>>> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>>>> (Adding linux-wireless) >>>>> >>>>> Arend or Rafa=C5=82, would you be able to look at this build problem?= Kbuild >>>>> found the build errors below, apparently a very old issue. It just >>>>> blames me now because I moved the driver to a new directory :) >>> >>> It is a very old issue. The thing is that the issue can not really occur >>> because we have this: >>> >>> # common flags >>> subdir-ccflags-$(CONFIG_BRCMDBG) +=3D -DDEBUG >>> >>> in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what >>> happens in the "kbuild test robot" scenario. >>=20 >> I actually tried to reproduce this with kbuild bot's instructions and >> was surprised to see that the build worked ok for me. So the issue is >> not that simple. > > Hi Kalle, > > Here is the old email exchange we had about this [1]. In my opinion this > is a Kbuild issue that needs to be looked into. > > Regards, > Arend > > [1] http://www.spinics.net/lists/linux-wireless/msg142122.html Heh, I had completely forgotten that we had discussed this before :) Fengguang and the kbuild bot team, do you have any ideas why only the bot is seeing this? --=20 Kalle Valo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [kbuild-all] drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' 2017-02-16 13:18 ` Kalle Valo @ 2017-02-17 1:45 ` Fengguang Wu 0 siblings, 0 replies; 8+ messages in thread From: Fengguang Wu @ 2017-02-17 1:45 UTC (permalink / raw) To: Kalle Valo Cc: Arend Van Spriel, Randy Dunlap, linux-wireless, linux-kernel, kbuild-all, Rafał Miłecki Hi Kalle, On Thu, Feb 16, 2017 at 03:18:48PM +0200, Kalle Valo wrote: >Arend Van Spriel <arend.vanspriel@broadcom.com> writes: > >> On 16-2-2017 11:01, Kalle Valo wrote: >>> Arend Van Spriel <arend.vanspriel@broadcom.com> writes: >>> >>>> On 16-2-2017 10:39, Rafał Miłecki wrote: >>>>> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>>>>> (Adding linux-wireless) >>>>>> >>>>>> Arend or Rafał, would you be able to look at this build problem? Kbuild >>>>>> found the build errors below, apparently a very old issue. It just >>>>>> blames me now because I moved the driver to a new directory :) >>>> >>>> It is a very old issue. The thing is that the issue can not really occur >>>> because we have this: >>>> >>>> # common flags >>>> subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG >>>> >>>> in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what >>>> happens in the "kbuild test robot" scenario. >>> >>> I actually tried to reproduce this with kbuild bot's instructions and >>> was surprised to see that the build worked ok for me. So the issue is >>> not that simple. >> >> Hi Kalle, >> >> Here is the old email exchange we had about this [1]. In my opinion this >> is a Kbuild issue that needs to be looked into. >> >> Regards, >> Arend >> >> [1] http://www.spinics.net/lists/linux-wireless/msg142122.html > >Heh, I had completely forgotten that we had discussed this before :) > >Fengguang and the kbuild bot team, do you have any ideas why only the >bot is seeing this? I guess the root cause is due to the robot's doing partial builds like these make drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.o make drivers/net/wireless/broadcom/brcm80211/brcmfmac/ The solution I come about is to climb up to higher level dirs like make drivers/net/wireless/ which is less likely to have Makefile tricks and still maintain fast enough build tests. Thanks, Fengguang ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-02-17 1:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201702071839.Ej9MjmlI%fengguang.wu@intel.com>
[not found] ` <ce7467a9-12d5-f64e-8b59-f9581db9f7c8@infradead.org>
2017-02-16 9:31 ` drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' Kalle Valo
2017-02-16 9:39 ` Rafał Miłecki
2017-02-16 9:53 ` Arend Van Spriel
2017-02-16 10:01 ` Kalle Valo
2017-02-16 10:30 ` Arend Van Spriel
2017-02-16 13:08 ` [kbuild-all] " Fengguang Wu
2017-02-16 13:18 ` Kalle Valo
2017-02-17 1:45 ` [kbuild-all] " Fengguang Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).