From: Kadianakis George <desnacked@gmail.com>
To: linux-wireless@vger.kernel.org
Subject: Function name collisions with mac80211
Date: Tue, 15 Dec 2009 03:25:50 +0200 [thread overview]
Message-ID: <873a3dm3j5.fsf@gmail.com> (raw)
Greetings,
a function name collision issue spawned off a Gentoo bug [1].
Basically, functions in the rtl8187se staging driver collide with functions in the
mac80211 source not allowing kernel compilation with both
CONFIG_RTL8187SE and CONFIG_MAC80211 set.
Changes that cause this issue are:
a) commit 103bf9f7d35849bce52ad412e4da5063b0716969:
mac80211: remove ieee80211_rx namespace hack
Where ieee80211_rx() starts getting exported instead of __ieee80211_rx() which used to get exported.
b) commit c6e43bc83fd0f156eeb64bc2fa47323fdff16ba8
Staging: rtl8187se/ieee80211: remove superfluous ieee80211_* defines
Where #define ieee80211_wake_queue ieee80211_wake_queue_rtl
and #define ieee80211_stop_queue ieee80211_stop_queue_rtl
get removed effectively exposing the collision with the mac80211
functions of the same names.
The collisions are not restricted to the rtl8187se driver, like the
following example:
c) commit 5d9baea95f45bddcecab050de1af2ef678e85339
Staging: rtl8192su: make private ieee80211 stack really private
Had the exact same effect as b) to the rtl8192su driver.
d) A quick grep of the three functions in Gentoo bug report shows many
instances of them in the drivers/staging directory.
[1]: http://bugs.gentoo.org/show_bug.cgi?id=296920
next reply other threads:[~2009-12-15 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 1:25 Kadianakis George [this message]
2009-12-15 1:42 ` Function name collisions with mac80211 John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a3dm3j5.fsf@gmail.com \
--to=desnacked@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).