From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Johannes Berg <johannes@sipsolutions.net>,
Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()
Date: Mon, 18 Jul 2022 13:22:22 +0200 [thread overview]
Message-ID: <874jzemzrl.fsf@toke.dk> (raw)
In-Reply-To: <9cc9b81d-75a3-3925-b612-9d0ad3cab82b@I-love.SAKURA.ne.jp>
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:
> lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1],
> for commit f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif
> that is being stopped") guards clear_bit() using fq.lock even before
> fq_init() from ieee80211_txq_setup_flows() initializes this spinlock.
>
> According to discussion [2], Toke was not happy with expanding usage of
> fq.lock. Since __ieee80211_wake_txqs() is called under RCU read lock, we
> can instead use synchronize_rcu() for flushing ieee80211_wake_txqs().
Ah, that's a neat solution! :)
Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
next prev parent reply other threads:[~2022-07-18 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:08 [syzbot] INFO: trying to register non-static key in ieee80211_do_stop syzbot
2022-07-17 2:32 ` [PATCH] wifi: mac80211: initialize fq.lock as early as possible Tetsuo Handa
2022-07-17 12:21 ` [PATCH v2] wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() Tetsuo Handa
2022-07-18 11:22 ` Toke Høiland-Jørgensen [this message]
2022-07-18 12:01 ` Kalle Valo
2022-07-26 6:55 ` Tetsuo Handa
2022-07-26 14:38 ` Kalle Valo
2022-07-26 15:05 ` Ben Greear
2022-07-26 21:38 ` Jakub Kicinski
2022-07-28 23:00 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jzemzrl.fsf@toke.dk \
--to=toke@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).