From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: do not wake queues on a vif that is being stopped
Date: Sun, 05 Jun 2022 19:23:37 +0200 [thread overview]
Message-ID: <874k0zowh2.fsf@toke.dk> (raw)
In-Reply-To: <20220531190824.60019-1-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> writes:
> When a vif is being removed and sdata->bss is cleared, __ieee80211_wake_txqs
> can still be called on it, which crashes as soon as sdata->bss is being
> dereferenced.
> To fix this properly, check for SDATA_STATE_RUNNING before waking queues,
> and take the fq lock when setting it (to ensure that __ieee80211_wake_txqs
> observes the change when running on a different CPU
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
I think it's a little ugly to expand usage of fq.lock across more and
more places, I don't really have a good alternative, so:
Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
next prev parent reply other threads:[~2022-06-05 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 19:08 [PATCH] mac80211: do not wake queues on a vif that is being stopped Felix Fietkau
2022-06-05 17:23 ` Toke Høiland-Jørgensen [this message]
2022-07-12 20:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k0zowh2.fsf@toke.dk \
--to=toke@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).