linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath11k: add thermal cooling device support
Date: Tue, 11 Feb 2020 15:34:25 +0200	[thread overview]
Message-ID: <874kvxxn6m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1580860830-12696-1-git-send-email-pradeepc@codeaurora.org> (Pradeep Kumar Chitrapu's message of "Wed, 5 Feb 2020 05:30:29 +0530")

Pradeep Kumar Chitrapu <pradeepc@codeaurora.org> writes:

> Thermal cooling device support is added to control the temperature by
> throttling the data transmission for the given duration. Throttling is
> done by suspending all data tx queues by given percentage of time. The
> thermal device allows user to configure duty cycle.
>
> Throttling can be disabled by setting the duty cycle to 0. The cooling
> device can be found under /sys/class/thermal/cooling_deviceX/.
> Corresponding soft link to this device can be found under phy folder.
>
> /sys/class/ieee80211/phy*/device/cooling_device.
>
> To set duty cycle as 40%,
>
> echo 40 >/sys/class/ieee80211/phy*/device/cooling_device/cur_state
>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>

[...]

> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: BSD-3-Clause-Clear

This had a warning:

drivers/net/wireless/ath/ath11k/thermal.h:1: Improper SPDX comment style for 'drivers/net/wireless/ath/ath11k/thermal.h', please use '/*' instead
drivers/net/wireless/ath/ath11k/thermal.h:1: Missing or malformed SPDX-License-Identifier tag in line 1

I fixed that in the pending branch.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      parent reply	other threads:[~2020-02-11 13:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05  0:00 [PATCH 1/2] ath11k: add thermal cooling device support Pradeep Kumar Chitrapu
2020-02-05  0:00 ` [PATCH 2/2] ath11k: add thermal sensor " Pradeep Kumar Chitrapu
2020-02-11 13:49   ` Kalle Valo
2020-02-05 18:14 ` [PATCH 1/2] ath11k: add thermal cooling " John Crispin
2020-02-11 13:34 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kvxxn6m.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).