* Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c
@ 2019-06-13 18:00 Nathan Huckleberry
2019-06-14 5:25 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Huckleberry @ 2019-06-13 18:00 UTC (permalink / raw)
To: eliad, kvalo, davem; +Cc: netdev, linux-wireless, clang-built-linux
Hey all,
I'm looking into cleaning up ignored warnings in the kernel so we can
remove compiler flags to ignore warnings.
There are two unused variables ('wl18xx_iface_ap_cl_limits' and
'wl18xx_iface_ap_go_limits') in drivers/net/wireless/ti/wl18xx/main.c.
These appear to be limits when using p2p devices, yet they are never
used.
Wanted to reach out for the best course of action to fix the warning.
https://github.com/ClangBuiltLinux/linux/issues/530
Thanks,
Nathan Huckleberry
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c
2019-06-13 18:00 Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c Nathan Huckleberry
@ 2019-06-14 5:25 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-06-14 5:25 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: eliad, davem, netdev, linux-wireless, clang-built-linux
Nathan Huckleberry <nhuck@google.com> writes:
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There are two unused variables ('wl18xx_iface_ap_cl_limits' and
> 'wl18xx_iface_ap_go_limits') in drivers/net/wireless/ti/wl18xx/main.c.
> These appear to be limits when using p2p devices, yet they are never
> used.
>
> Wanted to reach out for the best course of action to fix the warning.
>
> https://github.com/ClangBuiltLinux/linux/issues/530
The the variables were added in this commit:
commit 7845af35e0deeb7537de759ebc69d6395d4123bf
Author: Eliad Peller <eliad@wizery.com>
AuthorDate: Thu Jul 30 22:38:22 2015 +0300
Commit: Kalle Valo <kvalo@codeaurora.org>
CommitDate: Mon Aug 10 22:16:34 2015 +0300
wlcore: add p2p device support
And even that commit didn't use them, no idea why. Just send a patch
removing them, if someone needs them later they can be added again.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-14 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-13 18:00 Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c Nathan Huckleberry
2019-06-14 5:25 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).