From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] rtw88: fix unassigned rssi_level in rtw_sta_info
Date: Mon, 06 May 2019 15:35:03 +0300 [thread overview]
Message-ID: <874l67vk08.fsf@codeaurora.org> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D17EB4C9@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Mon, 6 May 2019 08:54:14 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> -----Original Message-----
>> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>> Sent: Monday, May 06, 2019 4:49 PM
>> To: Tony Chuang
>> Cc: linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH v2 4/5] rtw88: fix unassigned rssi_level in rtw_sta_info
>>
>> <yhchuang@realtek.com> writes:
>>
>> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> >
>> > The new rssi_level should be stored in si, otherwise the rssi_level will
>> > never be updated and get a wrong RA mask, which is calculated by the
>> > rssi level
>> >
>> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
>>
>> Stanislaw suggested that this should go to 5.2. So what breaks from
>> user's point of view if this is not applied?
>>
>
> If the rssi level remains unchanged, then we could choose wrong ra_mask.
> And some *bad rates* we be chosen by firmware.
> The most hurtful scene would be *noisy environment* such as office, or public.
> The latency would be high and overall throughput would be only half.
> (This was tested, such as 4x Mbps -> 1x Mbps)
Yeah, then this is definitely suitable for 5.2. Could you please resend
the patch and mention the symtomps in the commit log? And mark the patch
as "[PATCH 5.2 v3]" so that I can easily see it's for v5.2, please.
--
Kalle Valo
next prev parent reply other threads:[~2019-05-06 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 11:53 [PATCH v2 0/5] rtw88: minor fixes from suggestions during review yhchuang
2019-05-03 11:53 ` [PATCH v2 1/5] rtw88: add license for Makefile yhchuang
2019-05-03 12:11 ` Kalle Valo
2019-05-03 11:53 ` [PATCH v2 2/5] rtw88: pci: use ieee80211_ac_numbers instead of 0-3 yhchuang
2019-05-28 11:51 ` Kalle Valo
2019-05-03 11:53 ` [PATCH v2 3/5] rtw88: pci: check if queue mapping exceeds size of ac_to_hwq yhchuang
2019-05-03 11:53 ` [PATCH v2 4/5] rtw88: fix unassigned rssi_level in rtw_sta_info yhchuang
2019-05-06 8:48 ` Kalle Valo
2019-05-06 8:54 ` Tony Chuang
2019-05-06 12:35 ` Kalle Valo [this message]
2019-05-03 11:53 ` [PATCH v2 5/5] rtw88: more descriptions about LPS yhchuang
2019-05-03 12:04 ` [PATCH v2 0/5] rtw88: minor fixes from suggestions during review Kalle Valo
2019-05-06 8:40 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l67vk08.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).