From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Bob Copeland <me@bobcopeland.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Bob Copeland <me@bobcopeland.com>,
Bob Copeland <bobcopeland@fb.com>
Subject: Re: [PATCH] mac80211: fix pending queue hang due to TX_DROP
Date: Wed, 05 Sep 2018 12:52:11 +0200 [thread overview]
Message-ID: <874lf46wtg.fsf@toke.dk> (raw)
In-Reply-To: <20180905102259.16089-1-me@bobcopeland.com>
Bob Copeland <me@bobcopeland.com> writes:
> In our environment running lots of mesh nodes, we are seeing the
> pending queue hang periodically, with the debugfs queues file showing
> lines such as:
>
> 00: 0x00000000/348
>
> i.e. there are a large number of frames but no stop reason set.
>
> One way this could happen is if queue processing from the pending
> tasklet exited early without processing all frames, and without having
> some future event (incoming frame, stop reason flag, ...) to reschedule
> it.
>
> Exactly this can occur today if ieee80211_tx() returns false due to
> packet drops or power-save buffering in the tx handlers. In the
> past, this function would return true in such cases, and the change
> to false doesn't seem to be intentional.
Can confirm that this was not intentional; nice catch! :)
Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
-Toke
prev parent reply other threads:[~2018-09-05 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 10:22 [PATCH] mac80211: fix pending queue hang due to TX_DROP Bob Copeland
2018-09-05 10:52 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lf46wtg.fsf@toke.dk \
--to=toke@toke.dk \
--cc=bobcopeland@fb.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).