From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: RT2870 failure in kernel 4.12.8
Date: Mon, 04 Sep 2017 15:47:30 +0300 [thread overview]
Message-ID: <874lsipr4t.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <ac74a535-80f7-6211-62ca-1016302d24bd@lwfinger.net> (Larry Finger's message of "Fri, 1 Sep 2017 10:02:16 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 09/01/2017 09:31 AM, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>>
>>> On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
>>>> Should the patch to wireless-drivers be annotated with a Stable reference so
>>>> that it is added to 4.12 and 4.13?
>>>
>>> According to Documentation/networking/netdev-FAQ.txt networking patches
>>> should not be marked cc:stable, instead a decent commit log should
>>> be written describing a bugfix. Which I believe it is done for
>>> this patch.
>>
>> But that's for net and net-next trees, not for wireless trees. With
>> wireless patches we use "Cc: stable@..." references.
>
> I see that this patch was just pushed for 4.14. I hope it got the
> Stable annotation at that time.
Justo to be sure, my understanding is that we are here talking about
this commit:
rt2800: fix TX_PIN_CFG setting for non MT7620 chips
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=83ec489193894e52bd395eec470f4f7c4286d4a5
I applied that already last Wednesday and that was without "Cc: stable".
So now someone should follow Option 2, wait the commit to hit Linus'
tree (I expect it to happen some time this week) and then send a note to
the stable team:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-2
Or if the commit doesn't apply cleanly to v4.13 then Option 3 is of
course the better approach.
--
Kalle Valo
next prev parent reply other threads:[~2017-09-04 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:03 RT2870 failure in kernel 4.12.8 Larry Finger
2017-08-31 7:55 ` Stanislaw Gruszka
2017-08-31 8:25 ` Kalle Valo
2017-08-31 15:33 ` Larry Finger
2017-09-01 8:57 ` Stanislaw Gruszka
2017-09-01 14:31 ` Kalle Valo
2017-09-01 15:02 ` Larry Finger
2017-09-04 12:47 ` Kalle Valo [this message]
2017-09-02 8:22 ` Stanislaw Gruszka
2017-09-04 12:58 ` stable-kernel-rules: wireless and netdev-FAQ Kalle Valo
2017-09-01 2:06 ` RT2870 failure in kernel 4.12.8 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lsipr4t.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).