From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH 14/25] iwlwifi: mvm: overwrite skb info later
Date: Mon, 06 Feb 2017 16:01:41 +0200 [thread overview]
Message-ID: <874m07a056.fsf@codeaurora.org> (raw)
In-Reply-To: <20170203143812.7525-15-luca@coelho.fi> (Luca Coelho's message of "Fri, 3 Feb 2017 16:38:01 +0200")
Luca Coelho <luca@coelho.fi> writes:
> From: Johannes Berg <johannes.berg@intel.com>
>
> We don't really need clear the skb's status area nor store the
> dev_cmd into it until we really commit to the frame by handing
> it to the transport - defer those operations until just before
> we do that.
>
> This doesn't entirely fix the bug with frames not getting sent
> out after having been deferred due to DQA, because it doesn't
> restore the info->driver_data[0] place that was already set to
> zero (or another value) by the A-MSDU logic.
>
> Fixes: commit 24afba7690e4 ("iwlwifi: mvm: support bss dynamic alloc/dealloc of queues")
s/commit // :)
--
Kalle Valo
next prev parent reply other threads:[~2017-02-06 14:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 14:37 [PATCH 00/25] iwlwifi: updates intended for v4.11 2017-02-03 Luca Coelho
2017-02-03 14:37 ` [PATCH 01/25] iwlwifi: mvm: fix PS-Poll enablement Luca Coelho
2017-02-03 14:37 ` [PATCH 02/25] iwlwifi: mvm: support unification of INIT and RT images Luca Coelho
2017-02-03 14:37 ` [PATCH 03/25] iwlwifi: mvm: support v2 of mfuart load notification Luca Coelho
2017-02-03 14:37 ` [PATCH 04/25] iwlwifi: mvm: Use aux queue for offchannel frames in dqa Luca Coelho
2017-02-03 14:37 ` [PATCH 05/25] iwlwifi: mvm: cleanup incorrect and redundant define Luca Coelho
2017-02-03 14:37 ` [PATCH 06/25] iwlwifi: mvm: support new statistics APIs Luca Coelho
2017-02-03 14:37 ` [PATCH 07/25] iwlwifi: mvm: support new scan API Luca Coelho
2017-02-03 14:37 ` [PATCH 08/25] iwlwifi: mvm: always free inactive queue when moving ownership Luca Coelho
2017-02-03 14:37 ` [PATCH 09/25] iwlwifi: mvm: reduce usage of IEEE80211_SKB_CB() Luca Coelho
2017-02-03 14:37 ` [PATCH 10/25] iwlwifi: mvm: support new alive notification Luca Coelho
2017-02-03 14:37 ` [PATCH 11/25] iwlwifi: mvm: synchronize firmware DMA paging memory Luca Coelho
2017-02-03 14:37 ` [PATCH 12/25] iwlwifi: mvm: fix D3 replay counter value Luca Coelho
2017-02-03 14:38 ` [PATCH 13/25] iwlwifi: mvm: set AID to firmware only for associated stations Luca Coelho
2017-02-03 14:38 ` [PATCH 14/25] iwlwifi: mvm: overwrite skb info later Luca Coelho
2017-02-06 14:01 ` Kalle Valo [this message]
2017-02-03 14:38 ` [PATCH 15/25] iwlwifi: mvm/pcie: adjust A-MSDU tx_cmd length in PCIe Luca Coelho
2017-02-06 14:05 ` Kalle Valo
2017-02-06 14:31 ` Luca Coelho
2017-02-03 14:38 ` [PATCH 16/25] iwlwifi: mvm: release static queues on bcast release Luca Coelho
2017-02-03 14:38 ` [PATCH 17/25] iwlwifi: pcie: fix the set of DMA memory mask Luca Coelho
2017-02-03 14:38 ` [PATCH 18/25] iwlwifi: mvm: fix pending frame counter calculation Luca Coelho
2017-02-03 14:38 ` [PATCH 19/25] iwlwifi: mvm: align copy-break SKB payload for MQ RX Luca Coelho
2017-02-03 14:38 ` [PATCH 20/25] iwlwifi: mvm: cleanup iwl_mvm_tx_mpdu a bit Luca Coelho
2017-02-03 14:38 ` [PATCH 21/25] iwlwifi: remove unnecessary argument to iwl_drv_start() Luca Coelho
2017-02-03 14:38 ` [PATCH 22/25] iwlwifi: remove unnecessary cfg element in iwl_drv Luca Coelho
2017-02-03 14:38 ` [PATCH 23/25] iwlwifi: support two phys for a000 devices Luca Coelho
2017-02-03 14:38 ` [PATCH 24/25] iwlwifi: pcie: fix another RF-kill race Luca Coelho
2017-02-03 14:38 ` [PATCH 25/25] iwlwifi: mvm: support new beacon template command Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m07a056.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).