From: Kalle Valo <kvalo@codeaurora.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Johannes Berg <johannes.berg@intel.com>, linux-wireless@vger.kernel.org
Subject: Re: iwlwifi: fix kernel crash when unregistering thermal zone
Date: Fri, 27 Jan 2017 21:54:04 +0200 [thread overview]
Message-ID: <874m0k46ub.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1e6ae9d2-fef7-1ce0-53fc-4948f81ae27d@kernel.dk> (Jens Axboe's message of "Fri, 27 Jan 2017 12:48:11 -0700")
Jens Axboe <axboe@kernel.dk> writes:
> On 01/21/2017 05:59 AM, Kalle Valo wrote:
>> Jens Axboe <axboe@kernel.dk> wrote:
>>> A recent firmware change seems to have enabled thermal zones on the
>>> iwlwifi driver. Unfortunately, my device fails when registering the
>>> thermal zone. This doesn't stop the driver from attempting to unregister
>>> the thermal zone at unload time, triggering a NULL pointer deference in
>>> strlen() off the thermal_zone_device_unregister() path.
>>>
>>> Don't unregister if name is NULL, for that case we failed registering.
>>> Do the same for the cooling zone.
>>>
>>> Signed-off-by: Jens Axboe <axboe@fb.com>
>>
>> Patch applied to wireless-drivers.git, thanks.
>>
>> 92549cdc288f iwlwifi: fix kernel crash when unregistering thermal zone
>
> When is this going out?
Trying to send a pull request to Dave tomorrow.
--
Kalle Valo
next prev parent reply other threads:[~2017-01-27 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 22:22 iwlwifi: fix kernel crash when unregistering thermal zone Jens Axboe
2017-01-21 7:56 ` Kalle Valo
2017-01-21 12:59 ` Kalle Valo
[not found] ` <20170121125917.2E08F609D0@smtp.codeaurora.org>
2017-01-27 19:48 ` Jens Axboe
2017-01-27 19:54 ` Kalle Valo [this message]
2017-01-27 19:55 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2017-01-21 10:54 Coelho, Luciano
2017-01-21 11:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m0k46ub.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=axboe@kernel.dk \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).