* [PATCH 2/3] ssb: make ssb_sdio_switch_core static
2015-09-21 7:47 [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Rafał Miłecki
@ 2015-09-21 7:47 ` Rafał Miłecki
2015-09-21 16:10 ` Michael Büsch
2015-09-21 7:47 ` [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup Rafał Miłecki
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Rafał Miłecki @ 2015-09-21 7:47 UTC (permalink / raw)
To: Kalle Valo, linux-wireless, Michael Büsch
Cc: Hauke Mehrtens, Rafał Miłecki
It's used locally only.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/ssb/sdio.c | 2 +-
drivers/ssb/ssb_private.h | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ssb/sdio.c b/drivers/ssb/sdio.c
index b2d36f7..2278e43 100644
--- a/drivers/ssb/sdio.c
+++ b/drivers/ssb/sdio.c
@@ -200,7 +200,7 @@ out:
}
/* host must be already claimed */
-int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
+static int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
{
u8 coreidx = dev->core_index;
u32 sbaddr;
diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
index eb507a5..1d2256e 100644
--- a/drivers/ssb/ssb_private.h
+++ b/drivers/ssb/ssb_private.h
@@ -132,7 +132,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,
struct ssb_init_invariants *iv);
extern u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset);
-extern int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev);
extern int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx);
extern int ssb_sdio_hardware_setup(struct ssb_bus *bus);
extern void ssb_sdio_exit(struct ssb_bus *bus);
@@ -144,11 +143,6 @@ static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset)
{
return 0;
}
-static inline int ssb_sdio_switch_core(struct ssb_bus *bus,
- struct ssb_device *dev)
-{
- return 0;
-}
static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx)
{
return 0;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] ssb: make ssb_sdio_switch_core static
2015-09-21 7:47 ` [PATCH 2/3] ssb: make ssb_sdio_switch_core static Rafał Miłecki
@ 2015-09-21 16:10 ` Michael Büsch
0 siblings, 0 replies; 7+ messages in thread
From: Michael Büsch @ 2015-09-21 16:10 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Kalle Valo, linux-wireless, Hauke Mehrtens
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On Mon, 21 Sep 2015 09:47:19 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> It's used locally only.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/ssb/sdio.c | 2 +-
> drivers/ssb/ssb_private.h | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/ssb/sdio.c b/drivers/ssb/sdio.c
> index b2d36f7..2278e43 100644
> --- a/drivers/ssb/sdio.c
> +++ b/drivers/ssb/sdio.c
> @@ -200,7 +200,7 @@ out:
> }
>
> /* host must be already claimed */
> -int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
> +static int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
> {
> u8 coreidx = dev->core_index;
> u32 sbaddr;
> diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
> index eb507a5..1d2256e 100644
> --- a/drivers/ssb/ssb_private.h
> +++ b/drivers/ssb/ssb_private.h
> @@ -132,7 +132,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,
> struct ssb_init_invariants *iv);
>
> extern u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset);
> -extern int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev);
> extern int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx);
> extern int ssb_sdio_hardware_setup(struct ssb_bus *bus);
> extern void ssb_sdio_exit(struct ssb_bus *bus);
> @@ -144,11 +143,6 @@ static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset)
> {
> return 0;
> }
> -static inline int ssb_sdio_switch_core(struct ssb_bus *bus,
> - struct ssb_device *dev)
> -{
> - return 0;
> -}
> static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx)
> {
> return 0;
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup
2015-09-21 7:47 [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Rafał Miłecki
2015-09-21 7:47 ` [PATCH 2/3] ssb: make ssb_sdio_switch_core static Rafał Miłecki
@ 2015-09-21 7:47 ` Rafał Miłecki
2015-09-21 16:11 ` Michael Büsch
2015-09-21 16:10 ` [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Michael Büsch
2015-09-29 8:02 ` Kalle Valo
3 siblings, 1 reply; 7+ messages in thread
From: Rafał Miłecki @ 2015-09-21 7:47 UTC (permalink / raw)
To: Kalle Valo, linux-wireless, Michael Büsch
Cc: Hauke Mehrtens, Rafał Miłecki
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/ssb/ssb_private.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
index 1d2256e..426c805 100644
--- a/drivers/ssb/ssb_private.h
+++ b/drivers/ssb/ssb_private.h
@@ -133,7 +133,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,
extern u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset);
extern int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx);
-extern int ssb_sdio_hardware_setup(struct ssb_bus *bus);
extern void ssb_sdio_exit(struct ssb_bus *bus);
extern int ssb_sdio_init(struct ssb_bus *bus);
@@ -147,10 +146,6 @@ static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx)
{
return 0;
}
-static inline int ssb_sdio_hardware_setup(struct ssb_bus *bus)
-{
- return 0;
-}
static inline void ssb_sdio_exit(struct ssb_bus *bus)
{
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup
2015-09-21 7:47 ` [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup Rafał Miłecki
@ 2015-09-21 16:11 ` Michael Büsch
0 siblings, 0 replies; 7+ messages in thread
From: Michael Büsch @ 2015-09-21 16:11 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Kalle Valo, linux-wireless, Hauke Mehrtens
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Mon, 21 Sep 2015 09:47:20 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/ssb/ssb_private.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
> index 1d2256e..426c805 100644
> --- a/drivers/ssb/ssb_private.h
> +++ b/drivers/ssb/ssb_private.h
> @@ -133,7 +133,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,
>
> extern u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset);
> extern int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx);
> -extern int ssb_sdio_hardware_setup(struct ssb_bus *bus);
> extern void ssb_sdio_exit(struct ssb_bus *bus);
> extern int ssb_sdio_init(struct ssb_bus *bus);
>
> @@ -147,10 +146,6 @@ static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx)
> {
> return 0;
> }
> -static inline int ssb_sdio_hardware_setup(struct ssb_bus *bus)
> -{
> - return 0;
> -}
> static inline void ssb_sdio_exit(struct ssb_bus *bus)
> {
> }
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register
2015-09-21 7:47 [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Rafał Miłecki
2015-09-21 7:47 ` [PATCH 2/3] ssb: make ssb_sdio_switch_core static Rafał Miłecki
2015-09-21 7:47 ` [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup Rafał Miłecki
@ 2015-09-21 16:10 ` Michael Büsch
2015-09-29 8:02 ` Kalle Valo
3 siblings, 0 replies; 7+ messages in thread
From: Michael Büsch @ 2015-09-21 16:10 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Kalle Valo, linux-wireless, Hauke Mehrtens
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Mon, 21 Sep 2015 09:47:18 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> It isn't used anywhere out of ssb code and we don't (plan to) build
> pcihost_wrapper.c as a separated module.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/ssb/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index a48a743..8cf23a2 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -876,7 +876,6 @@ int ssb_bus_pcibus_register(struct ssb_bus *bus, struct pci_dev *host_pci)
>
> return err;
> }
> -EXPORT_SYMBOL(ssb_bus_pcibus_register);
> #endif /* CONFIG_SSB_PCIHOST */
>
> #ifdef CONFIG_SSB_PCMCIAHOST
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register
2015-09-21 7:47 [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Rafał Miłecki
` (2 preceding siblings ...)
2015-09-21 16:10 ` [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Michael Büsch
@ 2015-09-29 8:02 ` Kalle Valo
3 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2015-09-29 8:02 UTC (permalink / raw)
To: Rafał Miłecki
Cc: linux-wireless, Michael Büsch, Hauke Mehrtens
Rafał Miłecki <zajec5@gmail.com> writes:
> It isn't used anywhere out of ssb code and we don't (plan to) build
> pcihost_wrapper.c as a separated module.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Thanks, all three patches manually applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread