From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: enable ANI by default
Date: Thu, 19 Mar 2015 10:45:27 +0200 [thread overview]
Message-ID: <874mphl6jc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1426701700-21974-1-git-send-email-arnagara@qti.qualcomm.com> (Ashok Raj Nagarajan's message of "Wed, 18 Mar 2015 23:31:39 +0530")
Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> writes:
> ANI is currently not enabled by default. Enable this feature by default.
>
> Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>
You did not send this to ath10k list (and CC linux-wireless). Check the
instructions here:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches
Also the commit log doesn't tell anything. What is ANI and why should it
be enabled? What bug does this fix (if any)? How will the user see the
difference after this patch is applied?
As a rule of thumb, the commit log should tell any engineer (even one
who is not familiar with ath10k) how the behaviour changes after the
patch is applied. Think of your target group being distro maintainers,
ath10k users, kernel subsystem maintainers etc. No company internal
jargon or anything like that, write in plain english so that everyone
understand.
--
Kalle Valo
next prev parent reply other threads:[~2015-03-19 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:01 [PATCH 1/2] ath10k: enable ANI by default Ashok Raj Nagarajan
2015-03-18 18:01 ` [PATCH 2/2] ath10k: allow user to toggle ani_enable via debugfs Ashok Raj Nagarajan
2015-03-19 8:52 ` Kalle Valo
2015-03-19 8:45 ` Kalle Valo [this message]
2015-03-19 8:47 ` [PATCH 1/2] ath10k: enable ANI by default Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mphl6jc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=arnagara@qti.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox