From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:10737 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbbCLNVn (ORCPT ); Thu, 12 Mar 2015 09:21:43 -0400 From: Kalle Valo To: Rajkumar Manoharan CC: , Subject: Re: [PATCH 1/3] ath10k: add sysfs entry to configure quiet period References: <1424437452-28161-1-git-send-email-rmanohar@qti.qualcomm.com> <87lhj4yi0x.fsf@kamboji.qca.qualcomm.com> <20150310165323.GB11700@qca.qualcomm.com> Date: Thu, 12 Mar 2015 15:21:34 +0200 In-Reply-To: <20150310165323.GB11700@qca.qualcomm.com> (Rajkumar Manoharan's message of "Tue, 10 Mar 2015 22:23:24 +0530") Message-ID: <874mpquza9.fsf@kamboji.qca.qualcomm.com> (sfid-20150312_142147_119365_10A4876B) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Rajkumar Manoharan writes: > On Tue, Mar 10, 2015 at 05:43:58PM +0200, Kalle Valo wrote: >> Rajkumar Manoharan writes: >> >> > Add support to configure quiet period via sysfs entry. This will >> > be helpful to experiment different quiet period values along with >> > different duty cycle ratio. >> > >> > To configure quiet period as 30ms, >> > >> > echo 30 >/sys/class/ieee80211/phyX/device/quiet_period >> >> What's the justification? To me this looks like an ugly driver private >> hack. Why can't you use nl80211 or something else? > > As this is purely for testing purpose to play around with different > quiet period along with various throttling state, sysfs entry is used > instead of netlink testmode command. Instead of debugfs, sysfs entry is > selected to align with existing thermal interface. Please correct me if I'm wrong, but I consider sysfs as a stable user space interface. It's not meant for random testing stuff. -- Kalle Valo