From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/4] ath10k: implement fw stats for wmi-tlv
Date: Wed, 4 Feb 2015 10:49:55 +0200 [thread overview]
Message-ID: <874mr2uklo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422611244-20767-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 30 Jan 2015 10:47:20 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> There are some slight differences in fw stats
> (sic) in wmi-tlv.
>
> Firmware has changed the querying scheme and no
> longer requires the ping-pong to get all stats.
> The patchset doesn't change this behaviour so with
> wmi-tlv it's possible to see the following
> warnings when reading fw stats:
>
> ath10k_pci 0000:00:06.0: received unsolicited stats update event
>
> The logic in ath10k still produces correct results
> so this is harmless.
>
> I wonder how to deal with this in a sane way. An
> `if (op_ver == WMI_TLV)` is a little bad but
> having a new ar->fw_feature flag just for a debug
> facility like this is a bit silly. Or we can just
> drop the warning and leave a comment. Ideas?
I think we could just remove the warning.
> Michal Kazior (4):
> ath10k: add vdev stats processing
> ath10k: change request stats command prototype
> ath10k: add more wmi fw stat defines
> ath10k: implement fw stats for wmi-tlv
There was a conflict in patch 2 but 3-way merge solved it automatically.
Please check the result in the pending branch.
--
Kalle Valo
next prev parent reply other threads:[~2015-02-04 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 9:47 [PATCH 0/4] ath10k: implement fw stats for wmi-tlv Michal Kazior
2015-01-30 9:47 ` [PATCH 1/4] ath10k: add vdev stats processing Michal Kazior
2015-01-30 9:47 ` [PATCH 2/4] ath10k: change request stats command prototype Michal Kazior
2015-01-30 9:47 ` [PATCH 3/4] ath10k: add more wmi fw stat defines Michal Kazior
2015-01-30 9:47 ` [PATCH 4/4] ath10k: implement fw stats for wmi-tlv Michal Kazior
2015-02-04 8:49 ` Kalle Valo [this message]
2015-02-05 9:21 ` [PATCH 0/4] " Michal Kazior
2015-02-15 15:15 ` Kalle Valo
2015-02-16 7:08 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mr2uklo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).