From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH 3/3] ath10k: support 32+ stations.
Date: Tue, 23 Sep 2014 15:59:06 +0300 [thread overview]
Message-ID: <874mvyebmt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1411149890-12618-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Fri, 19 Sep 2014 11:04:50 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Support up to 32 stations when using CT firmware.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
> + if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features))
> + ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS_CT) - 1;
> + else if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
> ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS) - 1;
> else
> ar->free_vdev_map = (1LL << TARGET_NUM_VDEVS) - 1;
[...]
> +/* Over-rides for Candela Technologies firmware */
> +#define TARGET_10X_NUM_VDEVS_CT 32
> +#define TARGET_10X_NUM_PEERS_CT (32 + (TARGET_10X_NUM_VDEVS_CT))
> +#define TARGET_10X_AST_SKID_LIMIT_CT (TARGET_10X_NUM_PEERS_CT * TARGET_10X_NUM_PEER_AST)
[...]
> + if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features))
> + max_num_peers = TARGET_10X_NUM_PEERS_CT - 1;
Like I said before, this hardcoding of values using feature bits is not
going to work in the long run. It's better that these values come
directly from FW IEs as integers, that gives us a lot more flexibility
between firmware versions.
That's why I'll drop patches 2 and 3.
--
Kalle Valo
next prev parent reply other threads:[~2014-09-23 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 18:04 [PATCH 1/3] ath10k: use 64-bit vdev map greearb
2014-09-19 18:04 ` [PATCH 2/3] ath10k: support CT firmware flag greearb
2014-09-19 18:04 ` [PATCH 3/3] ath10k: support 32+ stations greearb
2014-09-23 12:59 ` Kalle Valo [this message]
2014-09-23 14:58 ` Ben Greear
2014-09-23 9:04 ` [PATCH 1/3] ath10k: use 64-bit vdev map Michal Kazior
2014-09-23 12:54 ` Kalle Valo
2014-09-23 14:21 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mvyebmt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).