From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/6] ath10k: remove pci features var
Date: Fri, 8 Aug 2014 14:01:03 +0300 [thread overview]
Message-ID: <874mxnz1n4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1407402212-29809-4-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 7 Aug 2014 11:03:29 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> The ATH10K_PCI_FEATURE_MSI_X was originally
> introduced to support both chips QCA988Xv1 and
> QCA988Xv2. Since v1 isn't supported anymore it
> doesn't make sense to keep the feature flag
> around. Since this is the last one remove the
> whole thing.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/pci.h
> +++ b/drivers/net/wireless/ath/ath10k/pci.h
> @@ -135,13 +135,6 @@ struct service_to_pipe {
> u32 pipenum;
> };
>
> -enum ath10k_pci_features {
> - ATH10K_PCI_FEATURE_MSI_X = 0,
> -
> - /* keep last */
> - ATH10K_PCI_FEATURE_COUNT
> -};
I wouldn't be too surprised if we need this again at some point. But we
can then add it back.
--
Kalle Valo
next prev parent reply other threads:[~2014-08-08 11:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:03 [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Michal Kazior
2014-08-07 9:03 ` [PATCH 1/6] ath10k: embed ar_pci inside ar Michal Kazior
2014-08-07 9:03 ` [PATCH 2/6] ath10k: remove target soc ps code Michal Kazior
2014-08-08 10:45 ` Kalle Valo
2014-08-08 11:00 ` Michal Kazior
2014-08-08 11:04 ` Kalle Valo
2014-08-09 18:21 ` Kalle Valo
2014-08-09 18:24 ` Kalle Valo
2014-08-07 9:03 ` [PATCH 3/6] ath10k: remove pci features var Michal Kazior
2014-08-08 11:01 ` Kalle Valo [this message]
2014-08-07 9:03 ` [PATCH 4/6] ath10k: group some pci probing helpers Michal Kazior
2014-08-07 9:03 ` [PATCH 5/6] ath10k: remove htc->stopped Michal Kazior
2014-08-07 9:03 ` [PATCH 6/6] ath10k: move fw init print Michal Kazior
2014-08-12 7:53 ` Kalle Valo
2014-08-14 8:27 ` Kalle Valo
2014-08-12 7:56 ` [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mxnz1n4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).