From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
<ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 1/6] ath10k: use inline ce_state structure
Date: Sun, 1 Sep 2013 09:34:24 +0300 [thread overview]
Message-ID: <874na582z3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=mBeWQLvaLUL4gnTENRbGUK_fTkj9bP3HP-OSzBwG0Dg@mail.gmail.com> (Michal Kazior's message of "Wed, 28 Aug 2013 07:32:50 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 28 August 2013 06:12, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> Simplifies memory managament of ce_state.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> Sorry, I noticed this only in my second review round:
>>
>>> --- a/drivers/net/wireless/ath/ath10k/pci.h
>>> +++ b/drivers/net/wireless/ath/ath10k/pci.h
>>> @@ -233,7 +233,10 @@ struct ath10k_pci {
>>> spinlock_t ce_lock;
>>>
>>> /* Map CE id to ce_state */
>>> - struct ce_state *ce_id_to_state[CE_COUNT_MAX];
>>> + struct ce_state ce_states[CE_COUNT_MAX];
>>> +
>>> + /* makes sure that dummy reads are atomic */
>>> + spinlock_t hw_v1_workaround_lock;
>>> };
>>
>> That lock doesn't look right. Is it a leftover from a rebase?
>
> Oh, good catch. I wonder how it got there..
I had patches pending on this patchset, so I removed the lock from this
patch and applied it.
--
Kalle Valo
next prev parent reply other threads:[~2013-09-01 6:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 6:57 [PATCH 0/6] ath10k: CE cleanups Michal Kazior
2013-08-21 6:57 ` [PATCH 1/6] ath10k: use inline ce_state structure Michal Kazior
2013-08-21 6:57 ` [PATCH 2/6] ath10k: remove ce_op_state Michal Kazior
2013-08-21 6:57 ` [PATCH 3/6] ath10k: remove unused ce_attr parameters Michal Kazior
2013-08-21 6:57 ` [PATCH 4/6] ath10k: rename hif_ce_pipe_info to ath10k_pci_pipe Michal Kazior
2013-08-21 6:57 ` [PATCH 5/6] ath10k: rename ce_state to ath10k_ce_pipe Michal Kazior
2013-08-21 6:57 ` [PATCH 6/6] ath10k: rename ce_ring_state to ath10k_ce_ring Michal Kazior
2013-08-27 6:11 ` [PATCH 0/6] ath10k: CE cleanups Kalle Valo
2013-08-27 11:07 ` [PATCH v2 " Michal Kazior
2013-08-27 11:07 ` [PATCH v2 1/6] ath10k: use inline ce_state structure Michal Kazior
2013-08-28 4:12 ` Kalle Valo
2013-08-28 5:32 ` Michal Kazior
2013-09-01 6:34 ` Kalle Valo [this message]
2013-08-27 11:07 ` [PATCH v2 2/6] ath10k: remove ce_op_state Michal Kazior
2013-08-27 11:08 ` [PATCH v2 3/6] ath10k: remove unused ce_attr parameters Michal Kazior
2013-08-27 11:08 ` [PATCH v2 4/6] ath10k: rename hif_ce_pipe_info to ath10k_pci_pipe Michal Kazior
2013-08-27 11:08 ` [PATCH v2 5/6] ath10k: rename ce_state to ath10k_ce_pipe Michal Kazior
2013-08-27 11:08 ` [PATCH v2 6/6] ath10k: rename ce_ring_state to ath10k_ce_ring Michal Kazior
2013-09-01 6:36 ` [PATCH v2 0/6] ath10k: CE cleanups Kalle Valo
2013-09-02 5:29 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874na582z3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox