From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] wl1271: add testmode support
Date: Mon, 21 Dec 2009 16:05:06 +0200 [thread overview]
Message-ID: <874onkzalp.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1261400310.3733.13.camel@johannes.local> (Johannes Berg's message of "Mon\, 21 Dec 2009 13\:58\:30 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Mon, 2009-12-21 at 14:36 +0200, Kalle Valo wrote:
>
>> + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
>> + if (!cmd)
>> + return -ENOMEM;
>> +
>> + /* copy the buffer to make it work with dma */
>> + memcpy(cmd, buf, buf_len);
>
> kmemdup() (more than once in the patch)
Oh, of course I should have used that :) I'll change this.
>> +#ifndef __WL1271_TESTMODE_H__
>> +#define __WL1271_TESTMODE_H__
>> +
>> +#include <net/mac80211.h>
>> +
>> +int wl1271_tm_cmd(struct ieee80211_hw *hw, void *data, int len);
>> +
>> +#endif /* __WL1271_TESTMODE_H__ */
>
> probably wouldn't bother with a file for one line ;)
Yeah, you have a point. I added just for consistency.
Thanks for the review.
--
Kalle Valo
next prev parent reply other threads:[~2009-12-21 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 12:36 [RFC PATCH] wl1271 testmode support Kalle Valo
2009-12-21 12:36 ` [RFC PATCH] wl1271: add " Kalle Valo
2009-12-21 12:58 ` Johannes Berg
2009-12-21 14:05 ` Kalle Valo [this message]
2009-12-22 7:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874onkzalp.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox