Re: [WIP PATCH] sdio support for wl12xx

[Kalle Valo <kalle.valo@iki.fi>]

Bob Copeland <me@bobcopeland.com> writes:

> Hi all,

Hi Bob,

> Here's a VERY rough patch containing SDIO support for wl12xx, not
> yet for applying.  However, it does load (with the proper setup code)
> on my Android dev phone, chip probe works, and probably the rest too,
> though I didn't get that far.

Very cool!

>  This also splits out spi driver so we have wl12xx.ko (core) and
> wl12xx_spi/_sdio.

For the upcoming 1271 support this might create some problems, but let's
worry that later.

> A big thanks to the Nokia engineers for making this as easy as inserting
> an io ops structure and shuffling some code around.  The actual SDIO
> read/write bits are largely identical to TI/Google's own GPLed driver,
> though I plan to rework them a bit before submitting this (see below).

>From a quick look this looks good to me, having separate io.c was a good
choice. I won't comment on the details yet because this is early stages
still.

Thanks a lot for doing this!

-- 
Kalle Valo