From: Kalle Valo <kalle.valo@iki.fi>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Always send a null data frame if TIM bit is set.
Date: Wed, 04 Mar 2009 12:55:41 +0200 [thread overview]
Message-ID: <874oy9h80i.fsf@litku.valot.fi> (raw)
In-Reply-To: <20090302145030.GA4660@myhost.users.atheros.com> (Vivek Natarajan's message of "Mon\, 2 Mar 2009 20\:20\:30 +0530")
Vivek Natarajan <vivek.natraj@gmail.com> writes:
> If the AP thinks we are in power save state eventhough we are not truly
> in that state, it sets the TIM bit and does not send a data frame unless
> we send a null data frame to correct the state in the AP.
> This might happen if the null data frame for wake up is lost in the air
> after we disable power save.
Not a bad idea. Of course the proper fix would be that the stack is
notified when the null frames transmission fails, but we don't have
that yet.
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -1457,8 +1457,7 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
> ieee80211_sta_wmm_params(local, ifmgd, elems.wmm_param,
> elems.wmm_param_len);
>
> - if (local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK &&
> - local->hw.conf.flags & IEEE80211_CONF_PS) {
> + if (local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) {
> directed_tim = ieee80211_check_tim(&elems, ifmgd->aid);
Please add a comment why IEEE80211_CONF_PS is not checked.
--
Kalle Valo
next prev parent reply other threads:[~2009-03-04 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 14:50 [PATCH] mac80211: Always send a null data frame if TIM bit is set Vivek Natarajan
2009-03-04 10:55 ` Kalle Valo [this message]
2009-04-01 4:15 ` Vivek Natarajan
2009-04-02 5:52 ` Kalle Valo
2009-04-02 10:02 ` Johannes Berg
2009-04-02 17:30 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oy9h80i.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).