From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A627194A49; Tue, 30 Jul 2024 10:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.145.95.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722333611; cv=none; b=Yl5O0etByBEffg5mJQVrOqZ1KkUBOmUzufhzhoXE40iwO46vfKQS83Is0R8S2zDKSiWB++AfInYCcnThyOn6JZr7LH53F73F9qIDa2EXl1o3Xt/CMaAcBeKziQIg33FNC2XxE4RBaN9F6FJ0sEB/MZBHbJm0kL9uBTpmkKcJhFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722333611; c=relaxed/simple; bh=VKVnO8jReJ4Bgh4LNYlqBwyBLVhtI+mxGjxwPRV7z8c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=R/RwcRQtKc7HkEnRF6TDuZyQwTkX6Gu2FqrqCGDJmPiT8c1K6YoEvjry6r8kFMtsttdpcGA0VsGSnnoAvBP/TPqHCKQgwptGHpyo1x84BYWzVLFBw/HDsLmKlXZa5nTQUJLvzZAxaAXMS00kzDhr4yUdKC60DoKEn57oAUpKu28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk; spf=pass smtp.mailfrom=toke.dk; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b=cFSTqbwb; arc=none smtp.client-ip=45.145.95.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toke.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="cFSTqbwb" From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1722333605; bh=VKVnO8jReJ4Bgh4LNYlqBwyBLVhtI+mxGjxwPRV7z8c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cFSTqbwbOGllqs/C6AyhNmJUNT8fIJHbdOndiuH51F2686RUEmCZA6gHtFjKxBGDb IY/iWUJjX+nc+CifkSvqMhjjmblcnY3jVahrkmYpAs0LrqKuJvwZBlM5GJ4xF/lANo ub9HkkIw/O3jrtgtT6rQaVFcqyqm9Dw5oM9V9eVInb73ZyA5GTz+XP4blXTSSV/qTv S62I5f4V0euyKGFzVlB8ixctYuXGCOXk6njbzTPOgKmTeLqVsBQdoftXTBe7xamPV+ RmXchCtPTrmIofgvjfPhRcMZ9hM8X2Jc/eGW1pSn3IbbHJB/BZDP/D7An47yKG0w92 YNodZsFf1FV5A== To: Heiner Kallweit , Kalle Valo , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivami , Martin Blumenstingl Cc: linux-wireless , "linux-arm-kernel@lists.infradead.org" , linux-actions@lists.infradead.org, "linux-pci@vger.kernel.org" Subject: Re: [PATCH v2] ath9k: use unmanaged PCI functions in ath9k_pci_owl_loader In-Reply-To: <3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com> References: <3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com> Date: Tue, 30 Jul 2024 11:59:50 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <875xsnp5d5.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Heiner Kallweit writes: > Only managed PCI resource in the driver is the iomapped bar. However the = bar > is unmapped in the same function. Therefore using the device-managed > versions just causes overhead, w/o any benefit. Once this is switched to = the > non-managed versions, there's nothing left to be managed for > pcim_enable_device(). Therefore we can reduce overhead here too and switc= h to > the non-managed version as well. This includes removing the no longer nee= ded > call to pcim_pin_device(). > > Signed-off-by: Heiner Kallweit Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen