Re: [PATCH v3 0/4] ath12k: Factory test mode support

[Kalle Valo <kvalo@kernel.org>]

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 6/11/2024 1:34 AM, Aaradhana Sahu wrote:
>
>> Device is booted in factory test mode for calibration.
>> The commands are sent from userspace application, which
>> is sent to firmware using wmi commands. Firmware sends
>> the response to driver as wmi events and driver sends
>> these events to the application via netlink message.
>> 
>> Also added changes related to correct pdev id access for
>> fw test cmd.
>> 
>> Aaradhana Sahu (3):
>>   wifi: ath: create common testmode_i.h file for ath drivers
>>   wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
>>   wifi: ath12k: add factory test mode support
>> 
>> Rajat Soni (1):
>>   wifi: ath12k: Fill pdev id for fw test cmd
>> 
>> ---
>> v3:
>>   -Rebased on latest ToT
>>   -Updated Tested-on Tag
>>   -Removed second parameter of ath12k_core_start()
>>   -Updated copyright
>> v2:
>>   -Rebased on latest ath ToT
>> ---
>> 
>>  drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++--
>>  drivers/net/wireless/ath/ath12k/Makefile      |   1 +
>>  drivers/net/wireless/ath/ath12k/core.c        |  22 +-
>>  drivers/net/wireless/ath/ath12k/core.h        |  13 +
>>  drivers/net/wireless/ath/ath12k/debug.h       |   1 +
>>  drivers/net/wireless/ath/ath12k/dp.c          |   3 +
>>  drivers/net/wireless/ath/ath12k/mac.c         |  15 +-
>>  drivers/net/wireless/ath/ath12k/pci.c         |   1 +
>>  drivers/net/wireless/ath/ath12k/testmode.c    | 422 ++++++++++++++++++
>>  drivers/net/wireless/ath/ath12k/testmode.h    |  40 ++
>>  drivers/net/wireless/ath/ath12k/wmi.c         |  39 +-
>>  drivers/net/wireless/ath/ath12k/wmi.h         |  21 +
>>  .../wireless/ath/{ath11k => }/testmode_i.h    |  52 +--
>>  13 files changed, 634 insertions(+), 74 deletions(-)
>>  create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c
>>  create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h
>>  rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (53%)
>> 
>> 
>> base-commit: a116bf2be795eb1db75fa6a48aa85c397be001a6
>
> FYI this series is not applying cleanly in my tree for validation:
>
> Base: using specified base-commit a116bf2be795eb1db75fa6a48aa85c397be001a6
> Applying: wifi: ath: create common testmode_i.h file for ath drivers
> Using index info to reconstruct a base tree...
> Patch failed at 0001 wifi: ath: create common testmode_i.h file for ath drivers
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> error: patch failed: drivers/net/wireless/ath/ath11k/testmode_i.h:4
> error: drivers/net/wireless/ath/ath11k/testmode_i.h: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
>
> I initially used b4, but tried again directly with git, and it failed for me 
> with both mechanisms.
> Kalle, do you have any issues with this series?

Also fails for me on top of commit a116bf2be795:

Applying: wifi: ath: create common testmode_i.h file for ath drivers
Using index info to reconstruct a base tree...
error: patch failed: drivers/net/wireless/ath/ath11k/testmode_i.h:4
error: drivers/net/wireless/ath/ath11k/testmode_i.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 wifi: ath: create common testmode_i.h file for ath drivers

Setting the patchset to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches