linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability
@ 2022-06-22  1:24 Peter Chiu
  2022-06-22  1:24 ` [PATCH 2/2] mt76: mt7915: add sta_rec with EXTRA_INFO_NEW for the first time only Peter Chiu
  2022-06-29 17:25 ` [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Chiu @ 2022-06-22  1:24 UTC (permalink / raw)
  To: Felix Fietkau
  Cc: Lorenzo Bianconi, Ryder Lee, Evelyn Tsai, Shayne Chen,
	linux-wireless, linux-mediatek, Peter Chiu

Set mpdu density to 2 usec in 6g capability.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
index 2764c2217..a2bc47162 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
@@ -979,7 +979,7 @@ mt7915_init_he_caps(struct mt7915_phy *phy, enum nl80211_band band,
 			u16 cap = IEEE80211_HE_6GHZ_CAP_TX_ANTPAT_CONS |
 				  IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
 
-			cap |= u16_encode_bits(IEEE80211_HT_MPDU_DENSITY_8,
+			cap |= u16_encode_bits(IEEE80211_HT_MPDU_DENSITY_2,
 					       IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START) |
 			       u16_encode_bits(IEEE80211_VHT_MAX_AMPDU_1024K,
 					       IEEE80211_HE_6GHZ_CAP_MAX_AMPDU_LEN_EXP) |
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] mt76: mt7915: add sta_rec with EXTRA_INFO_NEW for the first time only
  2022-06-22  1:24 [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Peter Chiu
@ 2022-06-22  1:24 ` Peter Chiu
  2022-06-29 17:25 ` [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Chiu @ 2022-06-22  1:24 UTC (permalink / raw)
  To: Felix Fietkau
  Cc: Lorenzo Bianconi, Ryder Lee, Evelyn Tsai, Shayne Chen,
	linux-wireless, linux-mediatek, Peter Chiu

From: Shayne Chen <shayne.chen@mediatek.com>

Set EXTRA_INFO_NEW for the first time only to prevent adding the same
starec entry, otherwise the entry might be removed in fw.

Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 793498175..395879923 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -235,7 +235,6 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
 	mt7915_mac_wtbl_update(dev, idx,
 			       MT_WTBL_UPDATE_ADM_COUNT_CLEAR);
 
-	rcu_assign_pointer(dev->mt76.wcid[idx], &mvif->sta.wcid);
 	if (vif->txq) {
 		mtxq = (struct mt76_txq *)vif->txq->drv_priv;
 		mtxq->wcid = idx;
@@ -251,6 +250,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
 
 	mt7915_mcu_add_bss_info(phy, vif, true);
 	mt7915_mcu_add_sta(dev, vif, NULL, true);
+	rcu_assign_pointer(dev->mt76.wcid[idx], &mvif->sta.wcid);
 
 out:
 	mutex_unlock(&dev->mt76.mutex);
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index 45fd844a4..b24692399 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -1663,7 +1663,8 @@ int mt7915_mcu_add_sta(struct mt7915_dev *dev, struct ieee80211_vif *vif,
 		return PTR_ERR(skb);
 
 	/* starec basic */
-	mt76_connac_mcu_sta_basic_tlv(skb, vif, sta, enable, true);
+	mt76_connac_mcu_sta_basic_tlv(skb, vif, sta, enable,
+			!rcu_access_pointer(dev->mt76.wcid[msta->wcid.idx]));
 	if (!enable)
 		goto out;
 
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability
  2022-06-22  1:24 [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Peter Chiu
  2022-06-22  1:24 ` [PATCH 2/2] mt76: mt7915: add sta_rec with EXTRA_INFO_NEW for the first time only Peter Chiu
@ 2022-06-29 17:25 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-06-29 17:25 UTC (permalink / raw)
  To: Peter Chiu
  Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Evelyn Tsai,
	Shayne Chen, linux-wireless, linux-mediatek

Peter Chiu <chui-hao.chiu@mediatek.com> writes:

> Set mpdu density to 2 usec in 6g capability.
>
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>

Why? The commit log should explain that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-29 17:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22  1:24 [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Peter Chiu
2022-06-22  1:24 ` [PATCH 2/2] mt76: mt7915: add sta_rec with EXTRA_INFO_NEW for the first time only Peter Chiu
2022-06-29 17:25 ` [PATCH 1/2] mt76: mt7915: update mpdu density in 6g capability Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).