From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AAF2C433EF for ; Thu, 16 Sep 2021 10:08:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C7D60EB6 for ; Thu, 16 Sep 2021 10:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235798AbhIPKJr (ORCPT ); Thu, 16 Sep 2021 06:09:47 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:19002 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbhIPKJr (ORCPT ); Thu, 16 Sep 2021 06:09:47 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631786907; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=sMyFM1XxKIFNAeT1EdCNPlgOLieY17FvRZjGIhPfWRI=; b=OkCph4eRl2/Jb7qqxQpYKxJFQ+5R+UMa5WFW680ivt4Pr0/+Aq3GOY7UltifWdMbjWsBguq1 MeDTnCVtxQVQkgA9kQj9A0QnTInmpjncFdp+tlL2AhCqsrsBmSQhYpe+IPTRJJByGBFVpZ/X j5TZtebDW6uA6paOC81FpG3dA38= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 61431790d914b0518240649c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 10:08:16 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 33962C43616; Thu, 16 Sep 2021 10:08:15 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 63B72C4338F; Thu, 16 Sep 2021 10:08:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 63B72C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Jouni Malinen Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Wen Gong Subject: Re: [PATCH 3/3] ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 References: <20210914163726.38604-1-jouni@codeaurora.org> <20210914163726.38604-3-jouni@codeaurora.org> Date: Thu, 16 Sep 2021 13:08:08 +0300 In-Reply-To: <20210914163726.38604-3-jouni@codeaurora.org> (Jouni Malinen's message of "Tue, 14 Sep 2021 19:37:26 +0300") Message-ID: <875yv0zvcn.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jouni Malinen writes: > From: Wen Gong > > Commit "ath11k: support SMPS configuration for 6 GHz" changed "if > (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS)" to "if (ht_cap & > WMI_HT_CAP_DYNAMIC_SMPS || ar->supports_6ghz)" which means > NL80211_FEATURE_DYNAMIC_SMPS is enabled for all chips which support 6 > GHz. However, WCN6855 supports 6 GHz but it does not support feature > NL80211_FEATURE_DYNAMIC_SMPS, and this can lead to MU-MIMO test failures > for WCN6855. > > Disable NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 since its ht_cap does > not support WMI_HT_CAP_DYNAMIC_SMPS. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > > Signed-off-by: Wen Gong > Signed-off-by: Jouni Malinen [...] > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -7570,7 +7570,8 @@ static int __ath11k_mac_register(struct ath11k *ar) > * for each band for a dual band capable radio. It will be tricky to > * handle it when the ht capability different for each band. > */ > - if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS || ar->supports_6ghz) > + if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS || > + (ar->supports_6ghz && !ab->hw_params.check_dynamic_smps)) > ar->hw->wiphy->features |= NL80211_FEATURE_DYNAMIC_SMPS; > > ar->hw->wiphy->max_scan_ssids = WLAN_SCAN_PARAMS_MAX_SSID; This hunk failed, in the pending branch as I don't have that ar->supports_6ghz check. I'll drop this patch 3 for now, let's revisit after my queue of ath11k patches is smaller. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches