From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: jikos@kernel.org, hdegoede@redhat.com, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs disabled
Date: Thu, 15 Apr 2021 19:04:32 +0300 [thread overview]
Message-ID: <875z0nlejz.fsf@codeaurora.org> (raw)
In-Reply-To: <bab37babea4f2972ef222e1dcaff7ab966ab15a8.camel@coelho.fi> (Luca Coelho's message of "Thu, 15 Apr 2021 16:52:35 +0300")
Luca Coelho <luca@coelho.fi> writes:
> On Thu, 2021-04-15 at 16:48 +0300, Luca Coelho wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> After the fix from Jiri that disabled local IRQs instead of
>> just BHs (necessary to fix an issue with submitting a command
>> with IRQs already disabled), there was still a situation in
>> which we could deep in there enable BHs, if the device config
>> sets the apmg_wake_up_wa configuration, which is true on all
>> 7000 series devices.
>>
>> To fix that, but not require reverting commit 1ed08f6fb5ae
>> ("iwlwifi: remove flags argument for nic_access"), split up
>> nic access into a version with BH manipulation to use most
>> of the time, and without it for this specific case where the
>> local IRQs are already disabled.
>>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> ---
>
> Kalle, I'm going to assign this one to you too, but this time for -next
> and not for -fixes.
>
> This is related to the fix Jiri made, but to avoid some conflicts and a
> broken v5.13-rc, we want to get it into v5.13 if still possible.
>
> So can you please take this on top of my latest pull request?
> Additionally, can you tag it for stable?
Will do.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-04-15 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:48 [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs disabled Luca Coelho
2021-04-15 13:52 ` Luca Coelho
2021-04-15 16:04 ` Kalle Valo [this message]
2021-04-18 6:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z0nlejz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).