From: Kalle Valo <kvalo@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
brcm80211-dev-list@cypress.com,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>
Subject: Re: [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size changes
Date: Fri, 22 May 2020 13:22:12 +0300 [thread overview]
Message-ID: <875zcob76z.fsf@codeaurora.org> (raw)
In-Reply-To: <09bf3506-2d25-d8a8-43eb-59a2e3d9a9ae@broadcom.com> (Arend Van Spriel's message of "Tue, 19 May 2020 19:00:21 +0200")
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On 5/19/2020 3:54 PM, Kalle Valo wrote:
>> Chi-Hsien Lin <chi-hsien.lin@cypress.com> writes:
>>
>>> Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
>>> settings for new firmware. Also fix a sparse check error.
>>
>> What ioctl is this exactly? Wireless drivers should be using nl80211,
>> not any ioctl interface.
>
> Hi Kalle,
>
> The terminology is a bit off. This is vendor specific command
> interfacing directly with firmware and the content is opaque from
> driver perspective.
Ah, you mean nl80211 vendor command. That has nothing to do with ioctl :)
> However, a number of these commands have their nl80211 equivalent.
> Especially regarding creation of AP interface I would simply go with
> creation through nl80211.
And do note that we have new rules for nl80211 vendor commands:
https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-05-22 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 11:09 [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size changes Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 1/4] brcmfmac: fix a sparse incorrect type error in p2p.c Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 2/4] brcmfmac: support virtual interface creation from firmware Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 3/4] brcmfmac: set net carrier on via test tool for AP mode Chi-Hsien Lin
2020-05-19 11:18 ` Arend Van Spriel
2020-05-21 9:27 ` Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 4/4] brcmfmac: increase dcmd maximum buffer size Chi-Hsien Lin
2020-05-19 11:29 ` Arend Van Spriel
2020-05-20 12:54 ` Chi-Hsien Lin
2020-05-19 13:54 ` [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size changes Kalle Valo
2020-05-19 17:00 ` Arend Van Spriel
2020-05-22 10:22 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zcob76z.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).