From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:47343 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933813AbeEIKRW (ORCPT ); Wed, 9 May 2018 06:17:22 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kalle Valo Cc: Johannes Berg , kbuild test robot , kbuild-all@01.org, linux-wireless@vger.kernel.org, Maya Erez Subject: Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes In-Reply-To: <87h8nhw2yf.fsf@kamboji.qca.qualcomm.com> References: <201805090154.h4Cokbx2%fengguang.wu@intel.com> <87efil2p2o.fsf@purkki.adurom.net> <1525855900.6910.5.camel@sipsolutions.net> <87tvrhw6kj.fsf@kamboji.qca.qualcomm.com> <1525856418.6910.6.camel@sipsolutions.net> <87efil41d4.fsf@toke.dk> <1525858618.6910.9.camel@sipsolutions.net> <87po25w463.fsf@kamboji.qca.qualcomm.com> <878t8t3zwp.fsf@toke.dk> <87h8nhw2yf.fsf@kamboji.qca.qualcomm.com> Date: Wed, 09 May 2018 12:17:15 +0200 Message-ID: <87603x3zh0.fsf@toke.dk> (sfid-20180509_121725_058440_ACFAC269) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >> Kalle Valo writes: >> >>> Johannes Berg writes: >>> >>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wr= ote: >>>>> Johannes Berg writes: >>>>>=20 >>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote: >>>>> > > Johannes Berg writes: >>>>> > >=20 >>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote: >>>>> > > > >=20 >>>>> > > > > I guess these warnings come because Toke's patch increased si= ze of >>>>> > > > > struct cfg80211_tid_stats (which is included in struct statio= n_info) and >>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from = stack?=20 >>>>> > > >=20 >>>>> > > > Yes. >>>>> > > >=20 >>>>> > > > > Can >>>>> > > > > someone send a fix for the drivers? >>>>> > > >=20 >>>>> > > > I guess Toke/I should do that through my tree. >>>>> > >=20 >>>>> > > IMHO the fix could go through my tree as well, less risk of confl= icts in >>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) wo= uld not >>>>> > > depend on Toke's patch and could be applied separately. >>>>> >=20 >>>>> > That's true, if you prefer that it's fine with me. >>>>>=20 >>>>> I'll send a patch. >>>>>=20 >>>>> What's the right tag to put in the commit for this? >>>>> Fixes-but-is-independent-from: ? ;) >>>> >>>> Heh. You can still put Fixes: I think. >>> >>> Yeah, I think so too. >> >> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver >> in staging; that should be fixed as well, right? In the same commit? > > Not in the same commit at least, I don't want to touch staging even with > a ten foot pole :) I guess either Greg or Johannes would take that > patch. Gotcha, I'll split that out :D -Toke