From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49778 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757545AbeD0MOj (ORCPT ); Fri, 27 Apr 2018 08:14:39 -0400 From: Kalle Valo To: Dan Carpenter Cc: Amitkumar Karwar , Prameela Rani Garnepudi , Siva Rebbagondla , Karun Eagalapati , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rsi: Uninitialized return value in rsi_reset_card() References: <20180426144235.GA25897@mwanda> Date: Fri, 27 Apr 2018 15:14:33 +0300 In-Reply-To: <20180426144235.GA25897@mwanda> (Dan Carpenter's message of "Thu, 26 Apr 2018 17:42:35 +0300") Message-ID: <87604calsm.fsf@purkki.adurom.net> (sfid-20180427_141444_281301_72C40BFF) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter writes: > If rsi_usb_master_reg_write() fails then "ret" hasn't been initialized. > > Fixes: 16d3bb7b2f37 ("rsi: disable fw watchdog timer during reset") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c > index b065438f51b2..6ce6b754df12 100644 > --- a/drivers/net/wireless/rsi/rsi_91x_usb.c > +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c > @@ -687,9 +687,10 @@ static int rsi_reset_card(struct rsi_hw *adapter) > */ > msleep(100); > > - if (rsi_usb_master_reg_write(adapter, SWBL_REGOUT, > - RSI_FW_WDT_DISABLE_REQ, > - RSI_COMMON_REG_SIZE) < 0) { > + ret = rsi_usb_master_reg_write(adapter, SWBL_REGOUT, > + RSI_FW_WDT_DISABLE_REQ, > + RSI_COMMON_REG_SIZE); > + if (ret < 0) { Odd, I thought I replied to this one already but I don't see my mail on patchwork. Anyway, Gustavo already submitted an identical patch: https://patchwork.kernel.org/patch/10365985/ -- Kalle Valo