From: Kalle Valo <kvalo@codeaurora.org>
To: govinds@codeaurora.org
Cc: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
linux-wireless@vger.kernel.org, pillair@codeaurora.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save
Date: Wed, 18 Apr 2018 16:16:07 +0300 [thread overview]
Message-ID: <87604oodt4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <7a06a34a5fcb97e07a8d79b4d689e781@codeaurora.org> (govinds@codeaurora.org's message of "Wed, 18 Apr 2018 18:37:26 +0530")
(fixing top posting)
govinds@codeaurora.org writes:
> On 2018-04-18 12:36, Sebastian Gottschall wrote:
>> from my point of view powersave should be optional and not forced.
>>
>> consider :
>> iw dev <devname> set power_save on/off
>>
>> so there is already a config option made for that purpose,
>
> Thanks Sebastian for your review. Agree this should not be forced with
> in driver.
>
> I will check if i can set the idle ps at the end of
> ath10k_mac_vif_setup_ps by checking arvif->ps.
> I will update the patch accordingly.
So what power save is this exactly? I assumed it's some bus level power
save (turning of clocks etc) but is it actually 802.11 power save?
--
Kalle Valo
next prev parent reply other threads:[~2018-04-18 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 12:06 [PATCH v2 0/4] Support for STA idle mode power save(IMPS) pillair
2018-04-17 12:06 ` [PATCH v2 1/4] ath10k: Add hw params for shadow register support pillair
2018-04-24 6:05 ` [v2,1/4] " Kalle Valo
2018-04-17 12:06 ` [PATCH v2 2/4] ath10k: Add support for shadow register for WNC3990 pillair
2018-04-17 12:07 ` [PATCH v2 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990 pillair
2018-04-17 12:07 ` [PATCH v2 4/4] ath10k: Enable sta idle power save pillair
2018-04-18 7:06 ` Sebastian Gottschall
2018-04-18 13:07 ` govinds
2018-04-18 13:16 ` Kalle Valo [this message]
2018-04-18 14:44 ` Arend van Spriel
2018-04-19 4:32 ` govinds
2018-04-19 16:36 ` Kalle Valo
2018-04-19 17:00 ` Adrian Chadd
2018-04-20 7:21 ` Sebastian Gottschall
2018-04-20 8:16 ` Arend van Spriel
2018-04-20 12:43 ` govinds
2018-04-23 15:50 ` Kalle Valo
2018-04-23 16:41 ` Adrian Chadd
2018-04-24 5:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87604oodt4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).