From: Kalle Valo <kvalo@codeaurora.org>
To: Pan Bian <bianpan2016@163.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: wireless: intersil: fix improper return value
Date: Wed, 07 Dec 2016 14:00:31 +0200 [thread overview]
Message-ID: <8760mwdk4g.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1480760572-4444-1-git-send-email-bianpan2016@163.com> (Pan Bian's message of "Sat, 3 Dec 2016 18:22:52 +0800")
Pan Bian <bianpan2016@163.com> writes:
> Function orinoco_ioctl_commit() returns 0 (indicates success) when the
> call to orinoco_lock() fails. Thus, the return value is inconsistent with
> the execution status. It may be better to return "-EBUSY" when the call
> to orinoco_lock() fails.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188671
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/net/wireless/intersil/orinoco/wext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please use prefix "orinoco:", more info:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name
--
Kalle Valo
next prev parent reply other threads:[~2016-12-07 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:22 [PATCH 1/1] net: wireless: intersil: fix improper return value Pan Bian
2016-12-07 12:00 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-03 10:18 Pan Bian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760mwdk4g.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=bianpan2016@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox