From: Kalle Valo <kvalo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: kbuild test robot <lkp@intel.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pontus Fuchs <pontus.fuchs@gmail.com>,
kbuild-all@01.org, wcn36xx@lists.infradead.org,
Eugene Krasnikov <k.eugene.e@gmail.com>
Subject: Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif
Date: Wed, 30 Mar 2016 08:18:45 +0300 [thread overview]
Message-ID: <8760w4bl1m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160329213721.GV8929@tuxbot> (Bjorn Andersson's message of "Tue, 29 Mar 2016 14:37:21 -0700")
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>> All error/warnings (new ones prefixed by >>):
>>
>> drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key':
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit declaration of function 'wcn36xx_sta_to_priv' [-Werror=implicit-function-declaration]
>> struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>> ^
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:33: warning: initialization makes pointer from integer without a cast
>> struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>> ^
>> cc1: some warnings being treated as errors
>
> This should have been reordered with patch 7, that introduces this
> helper function. Do you want me to resend, or can you apply the patches
> out of order?
It's better that you resend the whole patchset as v2.
--
Kalle Valo
next prev parent reply other threads:[~2016-03-30 5:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 6:06 [PATCH 00/16] Misc wcn36xx fixes Bjorn Andersson
2016-03-29 6:06 ` [PATCH 01/16] wcn36xx: Clean up wcn36xx_smd_send_beacon Bjorn Andersson
2016-03-29 6:06 ` [PATCH 02/16] wcn36xx: Pad TIM PVM if needed Bjorn Andersson
2016-03-29 6:06 ` [PATCH 03/16] wcn36xx: Add helper macros to cast vif to private vif and vice versa Bjorn Andersson
2016-03-29 6:06 ` [PATCH 04/16] wcn36xx: Use consistent name for private vif Bjorn Andersson
2016-03-29 6:06 ` [PATCH 05/16] wcn36xx: Use define for invalid index and fix typo Bjorn Andersson
2016-03-29 6:06 ` [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif Bjorn Andersson
2016-03-29 17:01 ` kbuild test robot
2016-03-29 21:37 ` Bjorn Andersson
2016-03-30 5:18 ` Kalle Valo [this message]
2016-03-29 6:06 ` [PATCH 07/16] wcn36xx: Add helper macros to cast sta to priv Bjorn Andersson
2016-03-29 6:06 ` [PATCH 08/16] wcn36xx: Remove sta pointer in private vif struct Bjorn Andersson
2016-03-29 6:06 ` [PATCH 09/16] wcn36xx: Parse trigger_ba response properly Bjorn Andersson
2016-03-29 6:06 ` [PATCH 10/16] wcn36xx: Copy all members in config_sta v1 conversion Bjorn Andersson
2016-03-29 6:06 ` [PATCH 11/16] wcn36xx: Use allocated self sta index instead of hard coded Bjorn Andersson
2016-03-29 6:06 ` [PATCH 12/16] wcn36xx: Clear encrypt_type when deleting bss key Bjorn Andersson
2016-03-29 6:06 ` [PATCH 13/16] wcn36xx: Track association state Bjorn Andersson
2016-03-29 6:06 ` [PATCH 14/16] wcn36xx: Implement multicast filtering Bjorn Andersson
2016-03-29 6:06 ` [PATCH 15/16] wcn36xx: don't pad beacons for mesh Bjorn Andersson
2016-03-29 12:45 ` Sergei Shtylyov
2016-03-29 21:41 ` [RESEND PATCH " Bjorn Andersson
2016-03-29 21:44 ` Bjorn Andersson
2016-03-29 6:06 ` [PATCH 16/16] wcn36xx: Use correct command struct for EXIT_BMPS_REQ Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760w4bl1m.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pontus.fuchs@gmail.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).