From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: fix scheduling while atomic bug
Date: Tue, 1 Oct 2013 19:35:45 +0300 [thread overview]
Message-ID: <8761th6ja6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380292567-2363-3-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 27 Sep 2013 16:36:07 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Recent WMI/HTC changes broke WEP with multiple
> keys. If WMI had no HTC TX credits to submit
> command for default wep index update it would
> trigger a bug.
>
> This simply moves the wep key index update to a
> worker.
>
> The key update may happen some time after first
> frame with a different wep key has been sent (i.e.
> some frames will be sent with old key). This was
> the case before too as WMI commands were
> asynchronous.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
This looks problematic. Basically you just delay sending the WMI
command, but there's no guarantee that we actually have free credits at
the time of transmission. So to me it looks like this fixes the issue
just by luck.
--
Kalle Valo
next prev parent reply other threads:[~2013-10-01 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:36 [PATCH 0/2] ath10k: fixes Michal Kazior
2013-09-27 14:36 ` [PATCH 1/2] ath10k: Fix bug in max. VHT A-MPDU size Michal Kazior
2013-10-01 16:27 ` Kalle Valo
2013-09-27 14:36 ` [PATCH 2/2] ath10k: fix scheduling while atomic bug Michal Kazior
2013-10-01 16:35 ` Kalle Valo [this message]
2013-10-02 5:35 ` Michal Kazior
2013-10-04 6:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761th6ja6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).