Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 05/13] ath10k: split ath10k_wmi_service_ready_event_rx
Date: Thu, 26 Sep 2013 15:38:39 +0300	[thread overview]
Message-ID: <8761tnrc4w.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380187792-25626-6-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 26 Sep 2013 11:29:44 +0200")

Bartosz Markowski <bartosz.markowski@tieto.com> writes:

> Since the both firmwares we are going to support,
> have significantly different APIs (WMI and shared
> structures), it's easier to actually split the whole
> event handling functions, instead cutting them inside.
>
> The fork starts now on ath10k_wmi_process_rx().
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>

[...]

> +	complete(&ar->wmi.service_ready);
> +}
> +
> +
>  static int ath10k_wmi_ready_event_rx(struct ath10k *ar, struct sk_buff *skb)

Only one empty line between functions.

-- 
Kalle Valo

  reply	other threads:[~2013-09-26 12:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  9:29 [PATCH v2 00/13] ath10k: dual-firmware support (MAIN and 10.X) Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 01/13] ath10k: introduce dynamic WMI structures Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 02/13] ath10k: add wmi_10x_<cmd/event> definitions Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 03/13] ath10k: warn if give WMI command is not supported Bartosz Markowski
2013-09-26 12:35   ` Kalle Valo
2013-09-26  9:29 ` [PATCH v2 04/13] ath10k: implement WMI events handling frame for both firmwares Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 05/13] ath10k: split ath10k_wmi_service_ready_event_rx Bartosz Markowski
2013-09-26 12:38   ` Kalle Valo [this message]
2013-09-26  9:29 ` [PATCH v2 06/13] ath10k: drop the fw versioning sanity check Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 07/13] ath10k: implement host memory chunks Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 08/13] ath10k: bring back the WMI path for mgmt frames Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 09/13] ath10k: split wmi_cmd_init path Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 10/13] ath10k: add TARGET values for 10.x firmware Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 11/13] ath10k: introduce dynamic vdev parameters Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 12/13] ath10k: introduce dynamic pdev parameters Bartosz Markowski
2013-09-26  9:29 ` [PATCH v2 13/13] ath10k: handle FW API differences for scan structures Bartosz Markowski
2013-09-26 13:05 ` [PATCH v2 00/13] ath10k: dual-firmware support (MAIN and 10.X) Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761tnrc4w.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=bartosz.markowski@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox