public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: avoid NULL ptr deref when using WEP
Date: Fri, 22 Jan 2010 23:03:50 +0200	[thread overview]
Message-ID: <87636trgw9.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1264181989-28483-1-git-send-email-linville@tuxdriver.com> (John W. Linville's message of "Fri\, 22 Jan 2010 12\:39\:49 -0500")

"John W. Linville" <linville@tuxdriver.com> writes:

> "mac80211: move control.hw_key assignment" changed an if-else into two
> separate if statments, but the if-else is needed to prevent
> dereferencing a null info->control.hw_key.  This fixes avoids a lock-up
> during association on my machine when using WEP.

Thanks. I was also suffering from this and your patch fixed it.

> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Tested-by: Kalle Valo <kalle.valo@iki.fi>

-- 
Kalle Valo

      parent reply	other threads:[~2010-01-22 21:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 17:39 [PATCH] mac80211: avoid NULL ptr deref when using WEP John W. Linville
2010-01-22 18:45 ` Johannes Berg
2010-01-22 21:03 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87636trgw9.fsf@purkki.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox