Re: [PATCH v3 0/2] mac80211: add U-APSD client support

[Kalle Valo <kalle.valo@iki.fi>]

Jason Young <a.young.jason@gmail.com> writes:

> On Mon, Dec 7, 2009 at 3:51 AM, Kalle Valo <kalle.valo@iki.fi> wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>>> #define IEEE80211_WMM_IE_STA_SP_ALL  (0<<5)
>>>> #define IEEE80211_WMM_IE_STA_SP_2     (1<<5)  /* or (BIT(5)) */
>>>> #define IEEE80211_WMM_IE_STA_SP_4     (2<<5)  /* or (BIT(6)) */
>>>> #define IEEE80211_WMM_IE_STA_SP_6     (3<<5)  /* or (BIT(5) | BIT(6)) */
>>>
>>> Can somebody clarify for me which part of this stuff is WMM, and which
>>> is "real" 802.11 QoS?
>
> Though this patch adds support for WMM Power Save, these defines will
> work for WMM and "real" 802.11 QoS.

Yes, I agree now.

>> I took a quick peek of the 802.11-2007 QoS part. My observation was
>> that the terms are the same, but that's about it. For example QoS Info
>> field is reversed, APSD capability is advertised through beacon
>> capability bits and naturally there are proper ids for IEs.
>
> The QoS info field itself is not reversed, the figure is just reversed.

Doh, I was reading it incorrectly in "IETF mode". Thank you for
correcting me.

-- 
Kalle Valo