* Re: [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver
[not found] <01c901ca4daf$6e3d7f20$4ab87d60$@Willis@Distant-earth.com>
@ 2009-10-16 7:52 ` Kalle Valo
2009-10-16 11:59 ` Bob Copeland
2009-11-08 18:57 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2009-10-16 7:52 UTC (permalink / raw)
To: John Willis; +Cc: me, linux-wireless
"John Willis" <John.Willis@Distant-earth.com> writes:
> Gents,
>
> Attached are some very hacky (even after a quick cleanup) patches that add
> something like support for reading the EEPROM NVS calibration data into the
> WL1251 driver. It seems just good enough to get the driver up and playing
> nicely.
Thanks a lot, this is good stuff. Now we have all hardware
configurations (known by me) supported in wl1251: SPI, SDIO, without
EEPROM and with EEPROM.
> I quickly rebased the patches on the top of wireless-testing, with any luck
> they still work however I can't test as there is something badly borked for
> OMAP3 in the mainline tree feeding WT at the moment. I have left out a lot
> of my development chaff and rubbish from the patches.
In cases like this I usually merge linux-omap to wireless-testing,
it's quite simple and fast thing to do. That way I get the omap
hardware booting with latest wireless stuff.
> They have only been tested on OMAP3 OpenPandora boards using SDIO. I still
> think timing needs tweaking but I have not had a chance to look into that.
I have few comments about the patch. I think it's better to configure
EEPROM support runtime and not via Kconfig. Also I don't like
hungarian notation :)
Is it okay if I clean it up a bit and then send it to John Linville?
Better to have the patch in the tree as early as possible, as long as it
doesn't break existing functionality. We can always fix it later if
there's something broken.
Thanks again for your patches and please keep on sending them :)
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver
[not found] <01c901ca4daf$6e3d7f20$4ab87d60$@Willis@Distant-earth.com>
2009-10-16 7:52 ` [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver Kalle Valo
@ 2009-10-16 11:59 ` Bob Copeland
2009-10-17 6:16 ` Kalle Valo
2009-11-08 18:57 ` Kalle Valo
2 siblings, 1 reply; 6+ messages in thread
From: Bob Copeland @ 2009-10-16 11:59 UTC (permalink / raw)
To: John Willis; +Cc: kalle.valo, linux-wireless
On Thu, Oct 15, 2009 at 04:51:49PM +0100, John Willis wrote:
> The patches are not yet complete but they do work for me (tm) so I would be
> very interested in seeing if these hacks also allow us to use the EEPROM on
> the HTC Dream (Bob, can you try that?, no rush however).
Yeah, I'll give it a spin. It'd be really nice if people don't need to
use the NVS file. Do you know the structure of the EEPROM data?
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver
2009-10-16 11:59 ` Bob Copeland
@ 2009-10-17 6:16 ` Kalle Valo
[not found] ` <034401ca4f0d$d494a140$7dbde3c0$@Willis@Distant-earth.com>
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2009-10-17 6:16 UTC (permalink / raw)
To: Bob Copeland; +Cc: John Willis, linux-wireless
Bob Copeland <me@bobcopeland.com> writes:
> On Thu, Oct 15, 2009 at 04:51:49PM +0100, John Willis wrote:
>> The patches are not yet complete but they do work for me (tm) so I would be
>> very interested in seeing if these hacks also allow us to use the EEPROM on
>> the HTC Dream (Bob, can you try that?, no rush however).
>
> Yeah, I'll give it a spin. It'd be really nice if people don't need to
> use the NVS file.
Didn't HTC Dream store the NVS file in the main flash memory? AFAIK
the EEPROM support in wl1251 needs a separate chip for the EEPROM, so
if someone has stored the NVS file to the main flash memory I really
doubt that they would still use EEPROM with wl1251. So the NVS file is
stored either to somewhere outside wl1251 or to the EEPROM, but not
both.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver
[not found] <01c901ca4daf$6e3d7f20$4ab87d60$@Willis@Distant-earth.com>
2009-10-16 7:52 ` [RFC] WL1251: Very crude EEPROM reading support for the WL1251 driver Kalle Valo
2009-10-16 11:59 ` Bob Copeland
@ 2009-11-08 18:57 ` Kalle Valo
[not found] ` <006b01ca60a6$60aa1f80$21fe5e80$@Willis@Distant-earth.com>
2 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2009-11-08 18:57 UTC (permalink / raw)
To: John Willis; +Cc: me, linux-wireless
"John Willis" <John.Willis@Distant-earth.com> writes:
> Gents,
Hi John,
> Attached are some very hacky (even after a quick cleanup) patches that add
> something like support for reading the EEPROM NVS calibration data into the
> WL1251 driver. It seems just good enough to get the driver up and playing
> nicely.
Sorry, but I found time to work on this patch only now. Busy schedules
etc :/
Now I noticed that the Signed-off-by line is missing, can you please
send that also? A reply to this email is enough.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread