From: Kalle Valo <kalle.valo@iki.fi>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] at76c50x-usb: support cfg80211 scanning
Date: Wed, 18 Feb 2009 22:31:30 +0200 [thread overview]
Message-ID: <8763j7qyfx.fsf@litku.valot.fi> (raw)
In-Reply-To: <c4d76b3b0902161643p73101b29hb55a9da696d16da9@mail.gmail.com> (Jason Andryuk's message of "Mon\, 16 Feb 2009 19\:43\:55 -0500")
Jason Andryuk <jandryuk@gmail.com> writes:
> With the latest mac80211 stack, the driver needs to be updated for
> cfg80211 scanning. I based the changes off of modifications for
> at76_usb found here:
> http://johannes.sipsolutions.net/patches/old/all/2008-09-19-13:35/020-cfg80211-scan.patch
>
> The trick was that max_signal also needs to be set to avoid a divide
> by zero Oops. I just guessed and used the value 100 for now.
Thank you for doing this. Unfortunately the patch was corrupted, so I
had to manually take your changes. I also included the
ieee80211_scan_compileted() fix to this patch.
> Additionally, I added some ieee80211_{wake,stop}_queues calls that
> were contained in the older at76_usb. There is ambiguity as to
> whether at76_join should be called before or after waking the queues.
I would like to have a separate patch for this. Also I would like to
know what kind of bug this fixes.
Sorry to be so picky, but I'm going to push the driver into mainline
soon and I try avoid regressions right now.
--
Kalle Valo
next prev parent reply other threads:[~2009-02-18 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 0:43 [PATCH] at76c50x-usb: support cfg80211 scanning Jason Andryuk
2009-02-18 20:31 ` Kalle Valo [this message]
2009-02-19 3:32 ` Jason Andryuk
2009-02-19 6:33 ` Kalle Valo
2009-02-20 4:07 ` Jason Andryuk
2009-02-21 7:57 ` Kalle Valo
2009-02-21 21:44 ` Jason Andryuk
2009-02-21 22:00 ` Jason Andryuk
2009-02-22 11:49 ` Kalle Valo
2009-02-22 23:54 ` Jason Andryuk
2009-02-23 3:29 ` Jason Andryuk
2009-02-22 11:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763j7qyfx.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=jandryuk@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).