RE: Request to update 8852a firmware of rtw89 to v0.13.8.0

[Pkshih <pkshih@realtek.com>]

> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> Behalf Of Kalle Valo
> Sent: Thursday, May 13, 2021 2:09 PM
> To: Brian Norris
> Cc: Pkshih; linux-firmware@kernel.org; linux-wireless@vger.kernel.org
> Subject: Re: Request to update 8852a firmware of rtw89 to v0.13.8.0
> 
> Brian Norris <briannorris@chromium.org> writes:
> 
> > On Tue, May 11, 2021 at 11:05 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> >>
> >> Pkshih <pkshih@realtek.com> writes:
> >>
> >> > Please help to update 8852a firmware.
> >> > This is first time I send a pull request. If anything is wrong,
> >> > please let me know.
> >>
> >> rtw89 driver is not in upstream yet, and it has not been reviewed
> >> either. I recommend holding off pulling the firmware until the driver is
> >> reviewed.
> >
> > FWIW, preliminary rtw89 firmware was already merged. This is just an update.
> >
> > I also wonder, what's the harm? People like me are actively testing
> > the early versions, and I've done a very barebones amount of review (I
> > hope to do more). It really helps me to have up-to-date firmware
> > published somewhere central -- I guess I can take GitHub instead, but
> > again, why not kernel.org? If anyone else is looking at testing, they
> > know where to get the pieces too, and we can compare results.
> 
> It can create confusion to the users if during review we make changes
> how firmware files are handled. Some drivers have windows style .ini
> files which are not ok in an upstream driver, there could be changes in
> the file format etc.
> 
> But I have no strong opinion here, my main motivation is just to try to
> keep things simple for maintaining the "interface" between
> linux-firmware and kernel wireless drivers. My preference is that the
> firmware files are ready for submission when a new driver is submitted
> for review, but the firmware files are submitted only after the driver
> is accepted.
> 

I think I can maintain the firmware in GitHub before driver is accepted,
and add some information about firmware version and link in the cover of
patchset. Then, people can take proper firmware.

--
Ping-Ke