From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
Dmitry Antipov <dmantipov@yandex.ru>
Subject: Re: [PATCH 3/3] wifi: ath9k: simplify internal time management
Date: Tue, 10 Dec 2024 10:58:44 +0100 [thread overview]
Message-ID: <877c877tbf.fsf@toke.dk> (raw)
In-Reply-To: <20241209155027.636400-3-dmantipov@yandex.ru>
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Prefer 'ktime_t' over 'struct timespec64' for 'struct ath_chanctx' and
> 'struct ath_softc' timestamps, choose standard kernel time API over an
> ad-hoc math in 'chanctx_event_delta()' and 'ath9k_hw_get_tsf_offset()',
> adjust related users. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Nice cleanup! Just one formatting nit:
[...]
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index 2f137856a823..cf664a0dedaa 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -247,10 +247,8 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start)
> if (!sc->cur_chan->offchannel && start) {
> /* restore per chanctx TSF timer */
> if (sc->cur_chan->tsf_val) {
> - u32 offset;
> -
> - offset = ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_ts,
> - NULL);
> + u32 offset = ath9k_hw_get_tsf_offset
> + (sc->cur_chan->tsf_ts, 0);
This turned into a really odd line break. Let's just keep the variable
definition on its own line like it was before, so we can keep the
function call the way it is as well...
-Toke
next prev parent reply other threads:[~2024-12-10 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 15:50 [PATCH 1/3] wifi: ath9k: cleanup ath_txq_skb_done() Dmitry Antipov
2024-12-09 15:50 ` [PATCH 2/3] wifi: ath9k: cleanup a few (mostly) TX-related routines Dmitry Antipov
2024-12-10 9:59 ` Toke Høiland-Jørgensen
2024-12-09 15:50 ` [PATCH 3/3] wifi: ath9k: simplify internal time management Dmitry Antipov
2024-12-10 9:58 ` Toke Høiland-Jørgensen [this message]
2024-12-10 11:37 ` Dmitry Antipov
2024-12-14 17:29 ` Toke Høiland-Jørgensen
2024-12-16 17:42 ` Jeff Johnson
2024-12-16 19:42 ` Toke Høiland-Jørgensen
2024-12-10 9:59 ` [PATCH 1/3] wifi: ath9k: cleanup ath_txq_skb_done() Toke Høiland-Jørgensen
2024-12-19 17:54 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c877tbf.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).