Re: [PATCH v4] wifi: ath12k: report tx bitrate for iw dev xxx station dump

[Kalle Valo <kvalo@kernel.org>]

Lingbo Kong <quic_lingbok@quicinc.com> writes:

> On 2024/2/26 23:37, Kalle Valo wrote:
>> Lingbo Kong <quic_lingbok@quicinc.com> writes:
>> 
>>> The tx bitrate of "iw dev xxx station dump" always show an invalid value
>>> "tx bitrate: 6.0MBit/s".
>>>
>>> To address this issue, parse the tx complete report from firmware and
>>> indicate the tx rate to mac80211.
>>>
>>> After that, "iw dev xxx station dump" show the correct tx bitrate such as:
>>> tx bitrate: 104.0 MBit/s MCS 13
>>> tx bitrate: 144.4 MBit/s MCS 15 short GI
>>> tx bitrate: 626.9 MBit/s 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0
>>> tx bitrate: 1921.5 MBit/s 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
>>>
>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>> Tested-on: QCN9274 hw2.0 PCI QCN9274 hw2.0 PCI
>>> WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>
>>> Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
>> Please use full englist words like transmit instead of tx. Also the
>> title could be simplified to:
>> wifi: ath12k: report station mode transmit rate to user space
>> Here I assumed this only works in station mode. Or does this also
>> support AP and P2P mode? The commit message should explain that.
>> 
>
> Ok, i will apply it in next version. Thanks for pointing out.

After rereading my comments maybe keep the title simple like:

  wifi: ath12k: report station mode transmit rate

But it would be good to clarify in the commit message what modes this is
supported. And what hardware families support this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches