From: Kalle Valo <kvalo@kernel.org>
To: gregory.greenman@intel.com
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 01/16] wifi: iwlwifi: fw: increase fw_version string size
Date: Thu, 12 Oct 2023 18:59:00 +0300 [thread overview]
Message-ID: <877cnrg7cr.fsf@kernel.org> (raw)
In-Reply-To: <20231012153950.f4465b4b4e2b.Idced2e8d63c492872edcde1a3ce2cdd6cc0f8eb7@changeid> (gregory greenman's message of "Thu, 12 Oct 2023 15:41:48 +0300")
gregory.greenman@intel.com writes:
> From: Gregory Greenman <gregory.greenman@intel.com>
>
> In reality 64 bytes are enough to hold fw version string,
> but some compilers can complain (with W=1) that output may be
> truncated when building this string with snprintf.
> Increase the size to avoid this sort of warnings and state
> explicitely that we want the size to be trancated to 32 bytes.
>
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Thanks, I don't see warnings from iwlwifi anymore.
Tested-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-10-12 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 12:41 [PATCH v2 01/16] wifi: iwlwifi: fw: increase fw_version string size gregory.greenman
2023-10-12 15:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnrg7cr.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).