From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9459EE4996 for ; Tue, 22 Aug 2023 13:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236121AbjHVN2C (ORCPT ); Tue, 22 Aug 2023 09:28:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236119AbjHVN2B (ORCPT ); Tue, 22 Aug 2023 09:28:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20752CEE for ; Tue, 22 Aug 2023 06:27:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A53A656B6 for ; Tue, 22 Aug 2023 13:27:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01EE1C433C7; Tue, 22 Aug 2023 13:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692710862; bh=H3lL4hRz7BWjICYi+JiYCyi4XJOYiVGuW3F+KajnREo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HRqqrVKDb+lhDrsTAvfLnbHvNGpIk8nIymTQhmXvBix6Gbi0FCZ4/f1kekLJ4JV7R gwuE+iRfw1WfJXr9X8xjWr9McipV15yxhN8dsbI1bE0mYh+qAf/KHH1yG/EN/08eRf X8tGXEvwtDTvNVHEDf33oBU6EPVDQ0O+CuqMb5kwiQ23ptjSJGG4wgFq3B2sKFqAzG aL2Xf17yrCA6HXXpWXsdWzej79xSbSXi3rC7+KEQ70AJYzZUOoOREuCp58SPxODkJv o0HOgDt/nOE2cfz6TinxF6WVgin+laFENI+m0EIYaXuWfX0Ghc4ZjKcuJy9LUCMWIi FPxxEMlhxCRHQ== From: Kalle Valo To: Jeff Johnson Cc: , linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 2/2] wifi: ath12k: fix undefined behavior with __fls in dp References: <20230821130343.29495-1-quic_hprem@quicinc.com> <20230821130343.29495-3-quic_hprem@quicinc.com> Date: Tue, 22 Aug 2023 16:27:39 +0300 In-Reply-To: (Jeff Johnson's message of "Mon, 21 Aug 2023 08:27:53 -0700") Message-ID: <877cpni4vo.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jeff Johnson writes: > On 8/21/2023 6:03 AM, Harshitha Prem wrote: >> When max virtual ap interfaces are configured in all the bands >> with ACS and hostapd restart is done every 60s, >> a crash is observed at random times because of handling the >> uninitialized peer fragments with fragment id of packet as 0. >> "__fls" would have an undefined behavior if the argument is passed >> as "0". Hence, added changes to handle the same. >> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 >> devices") > > this should be in the last section with the Signed-off-by > > see > I can fix that in the pending branch, no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches