* [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
@ 2023-07-12 13:14 Minjie Du
2023-07-12 14:01 ` Nicolas Escande
2023-08-13 15:27 ` Greenman, Gregory
0 siblings, 2 replies; 4+ messages in thread
From: Minjie Du @ 2023-07-12 13:14 UTC (permalink / raw)
To: Gregory Greenman, Kalle Valo, Minjie Du, Stephen Rothwell,
open list:INTEL WIRELESS WIFI LINK (iwlwifi), open list
Cc: opensource.kernel
Make IS_ERR() judge the debugfs_create_dir() function return
in iwl_mei_dbgfs_register().
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
index 54445f39f..e5d203a62 100644
--- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
@@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
{
mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
- if (!mei->dbgfs_dir)
+ if (IS_ERR(mei->dbgfs_dir))
return;
debugfs_create_ulong("status", S_IRUSR,
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
2023-07-12 13:14 [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register() Minjie Du
@ 2023-07-12 14:01 ` Nicolas Escande
2023-08-13 15:27 ` Greenman, Gregory
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Escande @ 2023-07-12 14:01 UTC (permalink / raw)
To: Minjie Du, Gregory Greenman, Kalle Valo, Stephen Rothwell,
open list:INTEL WIRELESS WIFI LINK (iwlwifi), open list
Cc: opensource.kernel
On Wed Jul 12, 2023 at 3:14 PM CEST, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
> {
> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> - if (!mei->dbgfs_dir)
> + if (IS_ERR(mei->dbgfs_dir))
> return;
same as the other one
>
> debugfs_create_ulong("status", S_IRUSR,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
2023-07-12 13:14 [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register() Minjie Du
2023-07-12 14:01 ` Nicolas Escande
@ 2023-08-13 15:27 ` Greenman, Gregory
2023-08-21 12:46 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Greenman, Gregory @ 2023-08-13 15:27 UTC (permalink / raw)
To: kvalo@kernel.org, duminjie@vivo.com, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: opensource.kernel@vivo.com
Hi,
On Wed, 2023-07-12 at 21:14 +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
> {
> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> - if (!mei->dbgfs_dir)
> + if (IS_ERR(mei->dbgfs_dir))
> return;
>
> debugfs_create_ulong("status", S_IRUSR,
The title should be:
wifi: iwlwifi: mei: ...
Also, why two parameters? It only fixes dbgfs_dir?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
2023-08-13 15:27 ` Greenman, Gregory
@ 2023-08-21 12:46 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-08-21 12:46 UTC (permalink / raw)
To: Greenman, Gregory
Cc: duminjie@vivo.com, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
opensource.kernel@vivo.com
"Greenman, Gregory" <gregory.greenman@intel.com> writes:
> Hi,
>
> On Wed, 2023-07-12 at 21:14 +0800, Minjie Du wrote:
>> Make IS_ERR() judge the debugfs_create_dir() function return
>> in iwl_mei_dbgfs_register().
>>
>> Signed-off-by: Minjie Du <duminjie@vivo.com>
>> ---
>> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> index 54445f39f..e5d203a62 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
>> {
>> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>>
>> - if (!mei->dbgfs_dir)
>> + if (IS_ERR(mei->dbgfs_dir))
>> return;
>>
>> debugfs_create_ulong("status", S_IRUSR,
>
> The title should be:
>
> wifi: iwlwifi: mei: ...
>
> Also, why two parameters? It only fixes dbgfs_dir?
It would be better to just remove the check, from debugfs_create_dir():
* NOTE: it's expected that most callers should _ignore_ the errors returned
* by this function. Other debugfs functions handle the fact that the "dentry"
* passed to them could be an error and they don't crash in that case.
* Drivers should generally work fine even if debugfs fails to init anyway.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-21 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 13:14 [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register() Minjie Du
2023-07-12 14:01 ` Nicolas Escande
2023-08-13 15:27 ` Greenman, Gregory
2023-08-21 12:46 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).