From: Kalle Valo <kvalo@kernel.org>
To: "Youghandhar Chintala \(Temp\)" <quic_youghand@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem
Date: Tue, 01 Nov 2022 11:01:33 +0200 [thread overview]
Message-ID: <877d0fgiaa.fsf@kernel.org> (raw)
In-Reply-To: <fd45187c-739c-cd5d-4d4b-ae6abad03a94@quicinc.com> (Youghandhar Chintala's message of "Mon, 31 Oct 2022 12:24:43 +0530")
(fixing quotation)
"Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com> writes:
> On 10/28/2022 12:19 AM, Jeff Johnson wrote:
>
>> On 10/26/2022 3:22 AM, Youghandhar Chintala wrote:
>>> +static void ath10k_qmi_add_wlan_ver_smem(struct ath10k *ar, char
>>> *fw_build_id)
>>
>> const char *fw_build_id?
>>
>>> +{
>>> + u8 *smem_table_ptr;
>>> + size_t smem_block_size;
>>> + const u32 version_string_size = 128;
>>
>> should you s/128/MAX_BUILD_ID_LEN/ since that is what is used to
>> size qmi->fw_build_id?
>>
>> or alternately have the caller pass fw_build_id length as a separate
>> param?
>
> Sure Jeff. Will address it in next version of patch.
BTW Youghandhar, your quotes were broken in this mail so your reply was
difficult to find. See here:
https://patchwork.kernel.org/project/linux-wireless/patch/20221026102257.19919-1-quic_youghand@quicinc.com/
If you are using Outlook, I recommend switching to an application which
respects standards more :) For example, some people seem to be happy
with Thunderbird.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-11-01 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 10:22 [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem Youghandhar Chintala
2022-10-26 12:11 ` kernel test robot
2022-10-27 18:49 ` Jeff Johnson
2022-10-31 6:54 ` Youghandhar Chintala (Temp)
2022-11-01 9:01 ` Kalle Valo [this message]
2022-11-01 9:08 ` Youghandhar Chintala (Temp)
2022-11-01 9:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d0fgiaa.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_youghand@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).