From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665D1C6379D for ; Thu, 19 Nov 2020 07:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05D89246BB for ; Thu, 19 Nov 2020 07:57:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="aEOgMsVU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726463AbgKSH5t (ORCPT ); Thu, 19 Nov 2020 02:57:49 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:29001 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgKSH5q (ORCPT ); Thu, 19 Nov 2020 02:57:46 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605772665; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=ubWtRfSgmS3H8djE3SH6JHW3ccCoPv5FcGUzlbWcFhY=; b=aEOgMsVUjylTTBE2HD2atGvSQy+YaTW4cxREP1+l8WDI2rWBRFnw1b9qLo8jxpAs+3G+t30b 7p/jr7hRmIobPq9RElVw1MgwM0cF/P+vUSECKeSGDeK7TEpryUCmpegqePrXl6UNf9XzLy1L 23WLW8upnAvWe/PCrwCx2NMCcoM= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5fb625799e87e16352d229da (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 19 Nov 2020 07:57:45 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58405C43460; Thu, 19 Nov 2020 07:57:44 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 59941C433ED; Thu, 19 Nov 2020 07:57:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 59941C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Qinglang Miao Cc: Solomon Peachy , "David S. Miller" , Jakub Kicinski , , , Subject: Re: [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common References: <20201119070842.1011-1-miaoqinglang@huawei.com> Date: Thu, 19 Nov 2020 09:57:39 +0200 In-Reply-To: <20201119070842.1011-1-miaoqinglang@huawei.com> (Qinglang Miao's message of "Thu, 19 Nov 2020 15:08:42 +0800") Message-ID: <877dqhvkwc.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Qinglang Miao writes: > Add the missing destroy_workqueue() before return from > cw1200_init_common in the error handling case. > > Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") This should be: Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") I can fix that. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches